Skip to content

feat: qodana lint #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mdovhopo wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

feat: qodana lint #206

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
16d8248
Update action.yaml
mdovhopo Nov 4, 2024
2730b86
feat: add aodana
mdovhopo Nov 4, 2024
5e36de2
fix: secret
mdovhopo Nov 4, 2024
abcc8f9
fix: remove sonar
mdovhopo Nov 4, 2024
691c878
fix: postprcomment
mdovhopo Nov 4, 2024
063c557
fix: token
mdovhopo Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions composite-actions/nodejs-generic-api/test-unit/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ inputs:
GCLOUD_AUTH:
description: "GCP Auth (staging)"
required: false
QODANA_TOKEN:
description: "QODANA_TOKEN"
required: true
GITHUB_TOKEN:
description: "GH token to comment on pr"
slack-channel:
description: Name of the channel to notify failing action
required: false
Expand Down Expand Up @@ -92,12 +97,15 @@ runs:
shell: bash
run: npm run test:cov

- name: Analyze with SonarCloud
uses: extenda/actions/sonar-scanner@v0
- name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2024.2
with:
sonar-host: https://sonarcloud.io
service-account-key: ${{ inputs.SECRET_AUTH }}
sonar-scanner: node
post-pr-comment: true
args: --coverage-dir,.coverage,--baseline,qodana.sarif.json
github-token: ${{ inputs.GITHUB_TOKEN }}
env:
QODANA_TOKEN: ${{ inputs.QODANA_TOKEN }}


- name: Notify Slack if failed
if: ${{ github.ref == 'refs/heads/master' && failure() && inputs.notify-slack-on-fail }}
Expand Down