fix: prevent crash when BigInt passed to res.status() #6944
+317
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes expressjs#6756 Previously, passing a BigInt to res.status() would cause an uncaught TypeError because JSON.stringify() cannot serialize BigInt values. The error occurred when trying to create the error message. Changes: - Replace JSON.stringify(code) with template literal and typeof - Error message now shows both the value and its type - Add comprehensive tests for BigInt and other invalid types
Contributor
|
This is a duplicate of #6848, with the same approach. |
- Use Object.prototype.toString.call() for null-prototype objects - String() works safely for primitives like BigInt - Avoids template literals that would crash on null-prototype objects - Added test case for Object.create(null) to prove the fix This improves upon the initial fix by handling the edge case mentioned in PR expressjs#6848 where Object.create(null) objects have no toString method.
Author
Thanks for pointing out the I've updated this PR to handle it properly. The fix now uses:
Added a test case specifically for All 13 tests pass |
This comment was marked as off-topic.
This comment was marked as off-topic.
Member
|
There's no crash here. Im sorry but misunderstanding the problem you're attempting to solve is a close from me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6756
Previously, passing a BigInt to res.status() would cause an uncaught TypeError because JSON.stringify() cannot serialize BigInt values. The error occurred when trying to create the error message.
Changes: