[eas-cli] Add eas update:embedded:delete command#3809
Draft
gwdp wants to merge 1 commit into
Draft
Conversation
|
✅ Thank you for adding the changelog entry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Lets users delete an embedded update from the CLI. Pairs with expo/universe#27767. Ref ENG-21466.
How
Mirrors
eas update:embedded:view/:list/:upload. Confirmation prompt unless--non-interactive;--jsonround-trips{ id }. MapsNOT_FOUND_ERRORto a friendly message via a newisEmbeddedUpdateNotFoundErrorhelper.The mutation wrapper uses inline types and an
eslint-disable graphql/template-stringsblock until the server mutation merges and codegen regeneratesgenerated.ts. Marked draft until then.Test Plan
yarn tsc --noEmit,yarn lintclean. 6 new unit tests: confirm-path, non-interactive, abort,--json, NOT_FOUND, unexpected rethrow.