[eas-cli] Add --max-duration-minutes flag to eas simulator:start#3806
Open
szdziedzic wants to merge 3 commits into
Open
[eas-cli] Add --max-duration-minutes flag to eas simulator:start#3806szdziedzic wants to merge 3 commits into
szdziedzic wants to merge 3 commits into
Conversation
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3806 +/- ##
==========================================
+ Coverage 57.39% 57.41% +0.03%
==========================================
Files 909 909
Lines 39386 39405 +19
Branches 8247 8251 +4
==========================================
+ Hits 22603 22622 +19
Misses 15316 15316
Partials 1467 1467 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Leave the upper-bound check to the server instead of capping it client-side. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Subscribed to pull request
Generated by CodeMention |
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
eas simulator:startalways used the server-derived default max run time for the underlying device run session, so there was no way to bound how long a remote simulator session stays alive before it is automatically stopped. This gives users control over that duration (e.g. to cap cost or keep a session up longer on paid plans).How
--max-duration-minutesinteger flag toeas simulator:start. The CLI only rejects negative values; the upper bound and plan gating are enforced server-side. When omitted, the backend default derived from the job run priority is used.maxRunTimeMinutesonCreateDeviceRunSessionInput.yarn generate-graphql-code(kept as a separate commit). This resync also pulls in unrelated backend schema evolution.Test Plan
yarn typecheck,yarn lint,yarn fmt:check— passyarn test src/commands/simulator— 5/5 passyarn generate-graphql-code