Skip to content

[eas-cli] Add --max-duration-minutes flag to eas simulator:start#3806

Open
szdziedzic wants to merge 3 commits into
mainfrom
szdziedzic/simulator-start-max-duration
Open

[eas-cli] Add --max-duration-minutes flag to eas simulator:start#3806
szdziedzic wants to merge 3 commits into
mainfrom
szdziedzic/simulator-start-max-duration

Conversation

@szdziedzic
Copy link
Copy Markdown
Contributor

@szdziedzic szdziedzic commented May 29, 2026

Why

eas simulator:start always used the server-derived default max run time for the underlying device run session, so there was no way to bound how long a remote simulator session stays alive before it is automatically stopped. This gives users control over that duration (e.g. to cap cost or keep a session up longer on paid plans).

How

  • Added a --max-duration-minutes integer flag to eas simulator:start. The CLI only rejects negative values; the upper bound and plan gating are enforced server-side. When omitted, the backend default derived from the job run priority is used.
  • Wired the flag through to maxRunTimeMinutes on CreateDeviceRunSessionInput.
  • Regenerated the GraphQL schema via yarn generate-graphql-code (kept as a separate commit). This resync also pulls in unrelated backend schema evolution.

Test Plan

  • yarn typecheck, yarn lint, yarn fmt:check — pass
  • yarn test src/commands/simulator — 5/5 pass
  • Schema regenerated with yarn generate-graphql-code

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@szdziedzic szdziedzic changed the title [eas-cli] Regenerate GraphQL schema [eas-cli] Add --max-duration-minutes flag to eas simulator:start May 29, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.41%. Comparing base (b5592e1) to head (088a32b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3806      +/-   ##
==========================================
+ Coverage   57.39%   57.41%   +0.03%     
==========================================
  Files         909      909              
  Lines       39386    39405      +19     
  Branches     8247     8251       +4     
==========================================
+ Hits        22603    22622      +19     
  Misses      15316    15316              
  Partials     1467     1467              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Leave the upper-bound check to the server instead of capping it client-side.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@szdziedzic szdziedzic requested a review from sjchmiela May 29, 2026 15:49
@szdziedzic szdziedzic marked this pull request as ready for review May 29, 2026 15:49
@szdziedzic szdziedzic added the no changelog PR that doesn't require a changelog entry label May 29, 2026
@github-actions
Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

@github-actions
Copy link
Copy Markdown

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog PR that doesn't require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant