[worker] Use runtime settings from storage#3801
Draft
sjchmiela wants to merge 2 commits into
Draft
Conversation
| } | ||
|
|
||
| if (config.npmCacheUrl) { | ||
| const npmCacheUrl = shouldUseCache('npm') ? config.npmCacheUrl : null; |
Contributor
There was a problem hiding this comment.
nice this is where we'll check for https://github.com/expo/universe/pull/27727
|
❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3801 +/- ##
==========================================
+ Coverage 57.30% 57.55% +0.26%
==========================================
Files 905 912 +7
Lines 39291 39556 +265
Branches 8235 8284 +49
==========================================
+ Hits 22510 22761 +251
- Misses 15314 15329 +15
+ Partials 1467 1466 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests.
How
How did you build this feature or fix this bug and why?
Test Plan
Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction.