[cocoapods] Proxy CocoaPods CDN source metadata#3726
Open
sjchmiela wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3726 +/- ##
==========================================
+ Coverage 56.51% 56.64% +0.14%
==========================================
Files 887 892 +5
Lines 38416 38541 +125
Branches 8007 8024 +17
==========================================
+ Hits 21707 21828 +121
- Misses 16611 16615 +4
Partials 98 98 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a3207d2 to
32715f4
Compare
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
|
Subscribed to pull request
Generated by CodeMention |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds CocoaPods podspec metadata proxying to
expo-cocoapods-proxyvia CocoaPods supported:source_providerplugin hook.When
EAS_BUILD_COCOAPODS_CACHE_URLis set, the plugin now registers a proxied CDN source backed by the existingtrunkrepo directory, then registers canonicalTrunkSourceas fallback. The proxied source rewrites CocoaPods CDN metadata requests to${EAS_BUILD_COCOAPODS_CACHE_URL}/cdn.cocoapods.org/without creating or warming a separate second CDN repo.Why
The existing proxy behavior covered pod source downloads through
Pod::Downloader::HttpandPod::Downloader::Git, but CocoaPods CDN podspec metadata is resolved throughPod::CDNSource, bypassing those downloaders. That allowed podspec metadata requests to go directly to CocoaPods/GitHub and hit rate limits.Behavior
sourceentries use the plugin-provided proxied source first.Validation
Based on
turtle-v2, iOS worker images use Ruby 3.2 and CocoaPods 1.13.0, 1.14.3, 1.15.2, or 1.16.2.rubocop --disable-pending-copson the modified Ruby files: no offensesgit diff --check: clean