[eas-cli] Add expoPackageVersion to build metadata#3725
Draft
sjchmiela wants to merge 11 commits into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3725 +/- ##
==========================================
+ Coverage 56.64% 56.70% +0.06%
==========================================
Files 892 897 +5
Lines 38541 38615 +74
Branches 8024 8030 +6
==========================================
+ Hits 21828 21893 +65
- Misses 16615 16623 +8
- Partials 98 99 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
expoPackageVersion to build metadata
|
✅ Thank you for adding the changelog entry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Persist the installed
expopackage version separately fromsdkVersionso server-side log uploads can reproduce the legacyexpo_package_versionDatadog tag without conflating it with SDK version.How
expoPackageVersionto build metadata schema/types.getExpoPackageVersionAsync(...)behavior into shared@expo/eas-build-job#getInstalledExpoPackageVersionAsync(...):node --print require.resolve('expo/package.json'),fs.readJson, semver validation, and the sameEAS_BUILD_EXPO_PACKAGE_VERSION_*UserErrors.collectMetadataAsync(...)now resolvesexpoPackageVersioninline withasyncResult(getInstalledExpoPackageVersionAsync(...)).value, so build creation and the existing internalupdateBuildMetadatapath send it alongside the rest of the build metadata.expo_package_versionfrom build metadata; the worker no longer resolves or mutates this field.Test Plan
CI should pass.