Skip to content

[eas-cli] Add expoPackageVersion to build metadata#3725

Draft
sjchmiela wants to merge 11 commits into
mainfrom
stanley/expo-package-version-metadata-20260513
Draft

[eas-cli] Add expoPackageVersion to build metadata#3725
sjchmiela wants to merge 11 commits into
mainfrom
stanley/expo-package-version-metadata-20260513

Conversation

@sjchmiela
Copy link
Copy Markdown
Contributor

@sjchmiela sjchmiela commented May 13, 2026

Why

Persist the installed expo package version separately from sdkVersion so server-side log uploads can reproduce the legacy expo_package_version Datadog tag without conflating it with SDK version.

How

  • Added expoPackageVersion to build metadata schema/types.
  • Moved the existing worker getExpoPackageVersionAsync(...) behavior into shared @expo/eas-build-job#getInstalledExpoPackageVersionAsync(...): node --print require.resolve('expo/package.json'), fs.readJson, semver validation, and the same EAS_BUILD_EXPO_PACKAGE_VERSION_* UserErrors.
  • collectMetadataAsync(...) now resolves expoPackageVersion inline with asyncResult(getInstalledExpoPackageVersionAsync(...)).value, so build creation and the existing internal updateBuildMetadata path send it alongside the rest of the build metadata.
  • Worker error-log tags now read expo_package_version from build metadata; the worker no longer resolves or mutates this field.

Test Plan

CI should pass.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.70%. Comparing base (ae65e74) to head (5eb632a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3725      +/-   ##
==========================================
+ Coverage   56.64%   56.70%   +0.06%     
==========================================
  Files         892      897       +5     
  Lines       38541    38615      +74     
  Branches     8024     8030       +6     
==========================================
+ Hits        21828    21893      +65     
- Misses      16615    16623       +8     
- Partials       98       99       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjchmiela sjchmiela changed the title Add expoPackageVersion to build metadata [eas-cli] Add expoPackageVersion to build metadata May 13, 2026
@github-actions
Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant