[build-tools] Upload workflow job outputs#3705
Open
sjchmiela wants to merge 1 commit into
Open
Conversation
|
Subscribed to pull request
Generated by CodeMention |
b7a03f9 to
096ec49
Compare
95f0db0 to
7cc71a0
Compare
096ec49 to
e98d716
Compare
7cc71a0 to
5a6bc2e
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3705 +/- ##
==========================================
+ Coverage 56.59% 56.64% +0.05%
==========================================
Files 888 889 +1
Lines 38496 38578 +82
Branches 8026 8036 +10
==========================================
+ Hits 21784 21849 +65
- Misses 16614 16632 +18
+ Partials 98 97 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5a6bc2e to
09c7fd9
Compare
|
❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This uploads declared workflow job outputs from
@expo/build-toolsfor both step-based and normal build execution paths.This PR is stacked on top of #3704, which preserves
outputsin Android/iOS build job payloads.Changes
steps.*.outputs.*references still work.success()andfailure()reflecting the final result.Validation
packages/build-tools:yarn test builders/__tests__/custom.test.ts builders/__tests__/common.test.ts utils/__tests__/outputs.test.tspackages/build-tools:yarn buildyarn oxfmt --check ...