Skip to content

[build-tools] Upload workflow job outputs#3705

Open
sjchmiela wants to merge 1 commit into
mainfrom
stanley/upload-build-job-outputs
Open

[build-tools] Upload workflow job outputs#3705
sjchmiela wants to merge 1 commit into
mainfrom
stanley/upload-build-job-outputs

Conversation

@sjchmiela
Copy link
Copy Markdown
Contributor

Summary

This uploads declared workflow job outputs from @expo/build-tools for both step-based and normal build execution paths.

This PR is stacked on top of #3704, which preserves outputs in Android/iOS build job payloads.

Changes

  • Add a build-context output upload path for normal Android/iOS builds.
  • Reuse the existing step-context output upload path for custom/repack builds so steps.*.outputs.* references still work.
  • Upload outputs during normal build finalization, including failure/finalization-failure paths, with success() and failure() reflecting the final result.
  • Skip output upload cleanly when outputs are absent or cloud workflow upload context is unavailable.
  • Add tests for custom build upload, normal build success/failure/finalization failure upload, build-context interpolation, and skip behavior.

Validation

  • packages/build-tools: yarn test builders/__tests__/custom.test.ts builders/__tests__/common.test.ts utils/__tests__/outputs.test.ts
  • packages/build-tools: yarn build
  • yarn oxfmt --check ...

@github-actions
Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

@sjchmiela sjchmiela force-pushed the stanley/job-outputs-schema branch from b7a03f9 to 096ec49 Compare May 11, 2026 10:53
@sjchmiela sjchmiela force-pushed the stanley/upload-build-job-outputs branch from 95f0db0 to 7cc71a0 Compare May 11, 2026 10:53
@sjchmiela sjchmiela force-pushed the stanley/job-outputs-schema branch from 096ec49 to e98d716 Compare May 11, 2026 10:56
@sjchmiela sjchmiela force-pushed the stanley/upload-build-job-outputs branch from 7cc71a0 to 5a6bc2e Compare May 11, 2026 10:56
@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

❌ Patch coverage is 59.09091% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.64%. Comparing base (f856d40) to head (09c7fd9).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/build-tools/src/utils/outputs.ts 50.00% 24 Missing ⚠️
packages/build-tools/src/builders/common.ts 85.72% 2 Missing ⚠️
packages/build-tools/src/builders/custom.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3705      +/-   ##
==========================================
+ Coverage   56.59%   56.64%   +0.05%     
==========================================
  Files         888      889       +1     
  Lines       38496    38578      +82     
  Branches     8026     8036      +10     
==========================================
+ Hits        21784    21849      +65     
- Misses      16614    16632      +18     
+ Partials       98       97       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from stanley/job-outputs-schema to main May 11, 2026 11:56
@sjchmiela sjchmiela force-pushed the stanley/upload-build-job-outputs branch from 5a6bc2e to 09c7fd9 Compare May 11, 2026 12:10
@github-actions
Copy link
Copy Markdown

❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md.
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant