-
Notifications
You must be signed in to change notification settings - Fork 34
[example][apollo-client][react-navigation] fix type errors #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| name: Checks | ||
|
|
||
| on: | ||
| push: | ||
| branches: [main] | ||
| pull_request: | ||
| types: [opened, synchronize] | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.event_name }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| checks: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: 🏗 Setup repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: 🏗 Setup Bun | ||
| uses: oven-sh/setup-bun@v2 | ||
| with: | ||
| bun-version: latest | ||
|
|
||
| - name: 📦 Install dependencies | ||
| run: bun install --frozen-lockfile | ||
|
|
||
| - name: 🔍 Check apps | ||
| run: | | ||
| bun run lint:apps | ||
| bun run typecheck:apps |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -41,6 +41,7 @@ | |
| "expo": "53.0.7", | ||
| "expo-module-scripts": "^4.1.7", | ||
| "graphql": "^16.9.0", | ||
| "react-dom": "19.1.0", | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. bun adds
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. interesting |
||
| "typescript": "~5.8.3" | ||
| }, | ||
| "peerDependencies": { | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,13 +5,16 @@ import { useEffect, useRef } from 'react'; | |
|
|
||
| import { ReduxExtensionAdapter } from './ReduxExtensionAdapter'; | ||
|
|
||
| export function useReactNavigationDevTools(ref: React.RefObject<NavigationContainerRef<any>>) { | ||
| export function useReactNavigationDevTools( | ||
| ref: React.RefObject<NavigationContainerRef<any> | null> | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. as #70 |
||
| ) { | ||
| const client = useDevToolsPluginClient('react-navigation'); | ||
| const adapterRef = useRef(new ReduxExtensionAdapter()); | ||
| // @ts-ignore: Override global | ||
| globalThis.__REDUX_DEVTOOLS_EXTENSION__ = { | ||
| connect: () => adapterRef.current, | ||
| }; | ||
| // @ts-ignore: useReduxDevToolsExtension does not accept null ref from NavigationContainerRefWithCurrent | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i guess the problem is actually from react-navigation/devtools |
||
| useReduxDevToolsExtension(ref); | ||
|
|
||
| useEffect(() => { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LinkProps is not generic type from newer expo-router