Fix JAX 0.8+ / PyMC v5 compat (supersedes #164)#165
Open
MilesCranmerBot wants to merge 27 commits intoexoplanet-dev:mainfrom
Open
Fix JAX 0.8+ / PyMC v5 compat (supersedes #164)#165MilesCranmerBot wants to merge 27 commits intoexoplanet-dev:mainfrom
MilesCranmerBot wants to merge 27 commits intoexoplanet-dev:mainfrom
Conversation
for more information, see https://pre-commit.ci
Co-authored-by: Dan Foreman-Mackey <dfm@dfm.io>
Co-authored-by: Dan Foreman-Mackey <dfm@dfm.io>
Co-authored-by: Dan Foreman-Mackey <dfm@dfm.io>
Co-authored-by: Dan Foreman-Mackey <dfm@dfm.io>
Co-authored-by: Dan Foreman-Mackey <dfm@dfm.io>
for more information, see https://pre-commit.ci
Co-authored-by: Dan Foreman-Mackey <dfm@dfm.io>
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a re-opened/superseding version of MilesCranmer's original PR #164, with additional small fixes needed to get CI fully green on current dependency stacks.
Context / links:
What changed vs #164:
jax>=0.8.0to[build-system].requiresso the PEP517 build env can importjaxduring CMake configure and build/install thecelerite2.jax.xla_opsextension (fixesModuleNotFoundError: celerite2.jax.xla_ops).jax.lib.xla_client(removed upstream in newer JAX).jax._src.dispatch.apply_primitive(and drop the pre-0.8 fallback since we require >=0.8).All GitHub Actions checks are passing on the fork branch before opening this PR.