Skip to content

Make missing files an explicit error #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IsaacG wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −4
Open

Make missing files an explicit error #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions bin/run-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,27 @@ cp -R ${fixtures_dir}/* "${tmp_fixtures_dir}"

# Iterate over all test directories
for test_file in $(find "${tmp_fixtures_dir}" -name '*.spec.js'); do
slug=$(echo "${test_file:${#tmp_fixtures_dir}+1}" | cut -d / -f 1)
test_dir=$(dirname "${test_file}")
test_dir_name=$(basename "${test_dir}")
fixture_dir="${test_file#tmp_fixtures_dir/}"
slug="${fixture_dir%%/*}"
test_dir="${test_file%/*}"
test_dir_name="${test_dir##*/}"
test_dir_path=$(realpath "${test_dir}")

bin/run.sh "${slug}" "${test_dir_path}" "${test_dir_path}"

for file in representation.txt mapping.json; do
expected_file="expected_${file}"
missing=0

echo "${test_dir_name}: comparing ${file} to ${expected_file}"

if ! diff "${test_dir_path}/${file}" "${test_dir_path}/${expected_file}"; then
for f in "${file}" "${expected_file}"; do
if ! [ -e "${test_dir_path}/${f}" ]; then
echo "File '${test_dir_path}/${f}' is unexpectedly missing"
missing=1
fi
done
if [ $missing -eq 1 ] || ! diff "${test_dir_path}/${file}" "${test_dir_path}/${expected_file}"; then
exit_code=1
fi
done
Expand Down
Loading