Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
81d8ec2
Move fast unit tests to fast-tests.yml
ArBridgeman May 6, 2026
40ffdb7
Apply changes to the PTB
ArBridgeman May 6, 2026
0f8abdd
Extract periodic-validation code
ArBridgeman May 6, 2026
c163f0d
Apply changes to the PTB for periodic-validation
ArBridgeman May 6, 2026
e5e6bc0
Add way to extend fast-tests.yml
ArBridgeman May 6, 2026
4b351f7
Fix unit tests
ArBridgeman May 6, 2026
70ec171
Apply changes to the PTB for fast-tests-extension
ArBridgeman May 6, 2026
85b3be8
Add way to extend slow-checks.yml
ArBridgeman May 6, 2026
ceda85f
Apply changes to the PTB for slow-checks-extension
ArBridgeman May 6, 2026
f823761
Fix spacing in extensions
ArBridgeman May 6, 2026
6193139
Add to .gitattributes
ArBridgeman May 6, 2026
6562e36
Add information about extensions
ArBridgeman May 8, 2026
78b961b
Add fast-tests to page
ArBridgeman May 8, 2026
d196f75
Reduce pr-merge as handled by periodic-validation
ArBridgeman May 8, 2026
492eab3
Add periodic-validation to documentation
ArBridgeman May 8, 2026
02e6580
Add periodic-validation to documentation
ArBridgeman May 8, 2026
035d668
Move pull request to alphabetize
ArBridgeman May 8, 2026
5eed9f4
Add clause to define why
ArBridgeman May 8, 2026
400af60
Remove slow-checks.yml as will be modified in later PR
ArBridgeman May 8, 2026
135e472
Switch to autodetect file is present and merge-gate not slow-check ex…
ArBridgeman May 8, 2026
f36ee10
Add merge-gate to .gitattributes
ArBridgeman May 8, 2026
92a8b25
Add periodic-validation to .gitattributes
ArBridgeman May 8, 2026
7a7be0b
Merge branch 'main' into feature/825_split_up_workflows_unit_tests_an…
ArBridgeman May 8, 2026
23edcfb
Fix failing test
ArBridgeman May 8, 2026
287bf59
Add changelog entry
ArBridgeman May 8, 2026
81a8e8f
Add unit tests to verify block works as expected
ArBridgeman May 8, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions .gitattributes
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,15 @@ doc/changes/changelog.md linguist-generated=true
.github/actions/python-environment/ext/get_poetry.py linguist-generated=true

# PTB GitHub Workflows (CI/CD & Publishing)
.github/workflows/build-and-publish.yml linguist-generated=true
.github/workflows/cd.yml linguist-generated=true
.github/workflows/check-release-tag.yml linguist-generated=true
.github/workflows/ci.yml linguist-generated=true
.github/workflows/gh-pages.yml linguist-generated=true
.github/workflows/matrix-*.yml linguist-generated=true
.github/workflows/pr-merge.yml linguist-generated=true
.github/workflows/report.yml linguist-generated=true
.github/workflows/build-and-publish.yml linguist-generated=true
.github/workflows/cd.yml linguist-generated=true
.github/workflows/check-release-tag.yml linguist-generated=true
.github/workflows/checks.yml linguist-generated=true
.github/workflows/ci.yml linguist-generated=true
.github/workflows/fast-tests.yml linguist-generated=true
.github/workflows/gh-pages.yml linguist-generated=true
.github/workflows/matrix-*.yml linguist-generated=true
.github/workflows/merge-gate.yml linguist-generated=true
.github/workflows/periodic-validation.yml linguist-generated=true
.github/workflows/pr-merge.yml linguist-generated=true
.github/workflows/report.yml linguist-generated=true
56 changes: 0 additions & 56 deletions .github/workflows/checks.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 0 additions & 10 deletions .github/workflows/ci.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 26 additions & 0 deletions .github/workflows/fast-tests-extension.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
name: Fast-Tests-Extension
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no template for this workflow by intention?
Why?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! I think I understood:

  • default workflow (generated from template) is fast-tests.yml
  • The yaml renderer has been enhanced to allow (%if sections
  • Such a section includes a call to an individual workflow file if such exists.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment to this file?
Or user guide?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good suggestions. I was planning on adding the doc-related points in this PR, just wanted to get an initial response first. Think I'd do both the user guide and a comment in one of the workflow files, like fast-tests.yml

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs have been added :)


on:
workflow_call:

jobs:
lint-imports:
name: Lint Imports
runs-on: ubuntu-24.04
permissions:
contents: read
steps:
- name: Check out Repository
id: check-out-repository
uses: actions/checkout@v6

- name: Set up Python & Poetry Environment
id: set-up-python-and-poetry-environment
uses: exasol/python-toolbox/.github/actions/python-environment@v7
with:
python-version: "3.10"
poetry-version: "2.3.0"

- name: Lint Imports
id: lint-imports
run: poetry run -- nox -s lint:import
45 changes: 45 additions & 0 deletions .github/workflows/fast-tests.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 11 additions & 0 deletions .github/workflows/merge-gate-extension.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
name: Slow-Checks-Extension

on:
workflow_call:

jobs:
test-python-environment:
name: Test python-environment Action
uses: ./.github/workflows/test-python-environment.yml
permissions:
contents: read
24 changes: 11 additions & 13 deletions .github/workflows/merge-gate.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

37 changes: 37 additions & 0 deletions .github/workflows/periodic-validation.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 0 additions & 16 deletions .github/workflows/pr-merge.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .workflow-patcher.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
workflows:
- name: checks
- name: fast-tests
step_customizations:
- action: REPLACE
job: run-unit-tests
Expand Down
15 changes: 15 additions & 0 deletions doc/changes/unreleased.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,25 @@

## Summary

In this major release, several modifications were made to the PTB's workflow templates:

* The periodic run which was previously executed in the `ci.yml` has been moved to its
Copy link
Copy Markdown
Collaborator Author

@ArBridgeman ArBridgeman May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should maybe add mention of pr-merge.yml too

own `periodic-validation.yml` and will run weekly. This also has been modified to
run the `slow-checks.yml` so that more complete linting and coverage information is
sent to Sonar.
* The unit tests job has been moved from `checks.yml` to its own `fast-tests.yml` file.
* Workflow extensions were added to `fast-tests` and `merge-gate`. This allows users to
add custom `fast-tests-extension.yml` and `merge-gate-extension.yml` files. For more
details, check out LINK TO BE ADDED (DOES NOT EXIST YET).

## Bugfix

* #563: Fixed merge-gate to prevent auto-merges from happening when integration tests failed

## Feature

* #829: Extended removing a job from a workflow to also remove it from the `needs` of another job
* #825: Created two workflows by splitting up previous ones:
* Moved the periodic jobs in `ci.yml` to its own `periodic-validation.yml`
* Moved the unit tests job in `checks.yml` to its own `fast-tests.yml`
* #730: Added workflow extensions to `fast-tests` and `merge-gate`
Loading