-
Notifications
You must be signed in to change notification settings - Fork 2
Feature/825 split up workflows unit tests and periodic runs #826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
81d8ec2
40ffdb7
0f8abdd
c163f0d
e5e6bc0
4b351f7
70ec171
85b3be8
ceda85f
f823761
6193139
6562e36
78b961b
d196f75
492eab3
02e6580
035d668
5eed9f4
400af60
135e472
f36ee10
92a8b25
7a7be0b
23edcfb
287bf59
81a8e8f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| name: Fast-Tests-Extension | ||
|
|
||
| on: | ||
| workflow_call: | ||
|
|
||
| jobs: | ||
| lint-imports: | ||
| name: Lint Imports | ||
| runs-on: ubuntu-24.04 | ||
| permissions: | ||
| contents: read | ||
| steps: | ||
| - name: Check out Repository | ||
| id: check-out-repository | ||
| uses: actions/checkout@v6 | ||
|
|
||
| - name: Set up Python & Poetry Environment | ||
| id: set-up-python-and-poetry-environment | ||
| uses: exasol/python-toolbox/.github/actions/python-environment@v7 | ||
| with: | ||
| python-version: "3.10" | ||
| poetry-version: "2.3.0" | ||
|
|
||
| - name: Lint Imports | ||
| id: lint-imports | ||
| run: poetry run -- nox -s lint:import | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| name: Slow-Checks-Extension | ||
|
|
||
| on: | ||
| workflow_call: | ||
|
|
||
| jobs: | ||
| test-python-environment: | ||
| name: Test python-environment Action | ||
| uses: ./.github/workflows/test-python-environment.yml | ||
| permissions: | ||
| contents: read |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| workflows: | ||
| - name: checks | ||
| - name: fast-tests | ||
| step_customizations: | ||
| - action: REPLACE | ||
| job: run-unit-tests | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,10 +2,25 @@ | |
|
|
||
| ## Summary | ||
|
|
||
| In this major release, several modifications were made to the PTB's workflow templates: | ||
|
|
||
| * The periodic run which was previously executed in the `ci.yml` has been moved to its | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should maybe add mention of |
||
| own `periodic-validation.yml` and will run weekly. This also has been modified to | ||
| run the `slow-checks.yml` so that more complete linting and coverage information is | ||
| sent to Sonar. | ||
| * The unit tests job has been moved from `checks.yml` to its own `fast-tests.yml` file. | ||
| * Workflow extensions were added to `fast-tests` and `merge-gate`. This allows users to | ||
| add custom `fast-tests-extension.yml` and `merge-gate-extension.yml` files. For more | ||
| details, check out LINK TO BE ADDED (DOES NOT EXIST YET). | ||
|
|
||
| ## Bugfix | ||
|
|
||
| * #563: Fixed merge-gate to prevent auto-merges from happening when integration tests failed | ||
|
|
||
| ## Feature | ||
|
|
||
| * #829: Extended removing a job from a workflow to also remove it from the `needs` of another job | ||
| * #825: Created two workflows by splitting up previous ones: | ||
| * Moved the periodic jobs in `ci.yml` to its own `periodic-validation.yml` | ||
| * Moved the unit tests job in `checks.yml` to its own `fast-tests.yml` | ||
| * #730: Added workflow extensions to `fast-tests` and `merge-gate` | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there no template for this workflow by intention?
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah! I think I understood:
fast-tests.yml(%ifsectionsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a comment to this file?
Or user guide?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good suggestions. I was planning on adding the doc-related points in this PR, just wanted to get an initial response first. Think I'd do both the user guide and a comment in one of the workflow files, like
fast-tests.ymlThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs have been added :)