Skip to content

test: Simulate ExecuteTxs failing #2365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Manav-Aggarwal wants to merge 1 commit into from
Closed

test: Simulate ExecuteTxs failing #2365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion execution/evm/execution.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,13 +211,18 @@ func (c *EngineClient) ExecuteTxs(ctx context.Context, txs [][]byte, blockHeight
ts = prevTimestamp + 1 // Subsequent blocks must have a higher timestamp.
}

// get current finalized block hash
c.mu.Lock()
Copy link
Contributor

@tac0turtle tac0turtle Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: use RWMutex

finalizedBlockHash := c.currentFinalizedBlockHash
c.mu.Unlock()

// update forkchoice to get the next payload id
var forkchoiceResult engine.ForkChoiceResponse
err = c.engineClient.CallContext(ctx, &forkchoiceResult, "engine_forkchoiceUpdatedV3",
engine.ForkchoiceStateV1{
HeadBlockHash: prevBlockHash,
SafeBlockHash: prevBlockHash,
FinalizedBlockHash: prevBlockHash,
FinalizedBlockHash: finalizedBlockHash,
},
&engine.PayloadAttributes{
Timestamp: ts,
Expand Down
16 changes: 14 additions & 2 deletions execution/evm/execution_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ package evm

import (
"context"
"log"
"math/big"
"testing"
"time"
Expand Down Expand Up @@ -82,9 +83,10 @@ func TestEngineExecution(t *testing.T) {

prevStateRoot := rollkitGenesisStateRoot
lastHeight, lastHash, lastTxs := checkLatestBlock(tt, ctx)
log.Println("lastTxs", lastTxs)
lastNonce := uint64(0)

for blockHeight := initialHeight; blockHeight <= 10; blockHeight++ {
for blockHeight := initialHeight; blockHeight <= 1; blockHeight++ {
nTxs := int(blockHeight) + 10
// randomly use no transactions
if blockHeight == 4 {
Expand All @@ -102,9 +104,18 @@ func TestEngineExecution(t *testing.T) {
payload, err := executionClient.GetTxs(ctx)
require.NoError(tt, err)
require.Lenf(tt, payload, nTxs, "expected %d transactions, got %d", nTxs, len(payload))
log.Println("nTxs", nTxs)

allPayloads = append(allPayloads, payload)

txs = make([]*ethTypes.Transaction, nTxs)
for i := range txs {
txs[i] = GetRandomTransaction(t, TEST_PRIVATE_KEY, TEST_TO_ADDRESS, CHAIN_ID, 22000, &lastNonce)
}
for i := range txs {
SubmitTransaction(t, txs[i])
}

// Check latest block before execution
beforeHeight, beforeHash, beforeTxs := checkLatestBlock(tt, ctx)
require.Equal(tt, lastHeight, beforeHeight, "Latest block height should match")
Expand All @@ -124,7 +135,7 @@ func TestEngineExecution(t *testing.T) {
lastHeight, lastHash, lastTxs = checkLatestBlock(tt, ctx)
require.Equal(tt, blockHeight, lastHeight, "Latest block height should match")
require.NotEmpty(tt, lastHash.Hex(), "Latest block hash should not be empty")
require.GreaterOrEqual(tt, lastTxs, 0, "Number of transactions should be non-negative")
require.Equal(tt, lastTxs, nTxs, "Number of transactions should be equal")

if nTxs == 0 {
require.Equal(tt, prevStateRoot, newStateRoot)
Expand All @@ -141,6 +152,7 @@ func TestEngineExecution(t *testing.T) {

// start new container and try to sync
t.Run("Sync chain", func(tt *testing.T) {
tt.Skip("Skip sync chain")
jwtSecret := SetupTestRethEngine(t, DOCKER_PATH, JWT_FILENAME)

executionClient, err := NewEngineExecutionClient(
Expand Down
Loading