fix(tool): include quality fields in output schema#128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
FetchResponsenow serializes quality fields (word_count,redirect_chain,is_paywall) but the tool's advertised JSON output schema had"additionalProperties": falseand omitted these fields, causing strict consumers to reject otherwise valid responses.Description
word_count,redirect_chain, andis_paywallto thebuild_output_schema()properties so the schema matches serializedFetchResponseoutput.test_tool_schemasunit test to assert those three properties exist in the output schema.cargo fmtas part of the change surface.Testing
cargo fmt --allwhich completed successfully.cargo test -p fetchkit test_tool_schemasand thetest_tool_schemasassertion passed.Codex Task