fix(fetchkit): tighten content-type checks for markdown and text#125
Merged
chaliy merged 2 commits intoMay 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
text/htmlresponses that include parameters likeprofile="text/markdown"as markdown or plain text, allowing raw HTML (including<script>/iframe) to bypass the HTML conversion sanitization.Description
is_markdown_content_typeandis_plain_text_content_typeto parse only the primary media type token (the part before;) and compare it witheq_ignore_ascii_caseafter trimming.text/html; profile="text/markdown"andtext/html; profile="text/plain"are not treated as markdown/plain text.text/markdownandtext/plainmedia types while preventing parameter-based spoofing.Testing
cargo test -p fetchkit is_markdown_content_typeand the updatedtest_is_markdown_content_typepassed.cargo test -p fetchkit is_plain_text_content_typeand the updatedtest_is_plain_text_content_typepassed.Codex Task