ci(nightly): raise ASAN timeout to 90 minutes#1761
Merged
Conversation
The ASAN job consistently cancels at exactly 30 minutes — both the 2026-05-24 and 2026-05-25 runs stopped at the same retry::tests::* boundary and were killed by the per-job timeout. The single-threaded ASAN suite has grown well past 30 minutes (expanded rg differential corpus plus the coreutils differential harness), so the cap needs to move. 90 minutes leaves headroom for further test growth without masking real hangs.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 01816af | Commit Preview URL Branch Preview URL |
May 25 2026, 03:08 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bump the
AddressSanitizerjob'stimeout-minutesin.github/workflows/nightly.ymlfrom 30 → 90.Why
The ASAN job has cancelled on the last two nightly runs (2026-05-24 and 2026-05-25), both at exactly 30 minutes into the run, both at the same
builtins::retry::tests::*boundary in the output. That's thetimeout-minutes: 30cap firing — the test suite simply needs more wall time under--test-threads=1with the expandedrgdifferential corpus and the coreutils differential harness added since the previous successful run on 2026-05-23.Other nightly jobs (Miri, Security Analysis) finish well within their existing budgets and are unaffected.
How
Single
timeout-minutesvalue bumped to 90, with a comment explaining why.Risk
Testing
Generated by Claude Code