fix(rg): skip indexed prefilter for --crlf searches#1753
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | c950eb6 | Commit Preview URL | May 25 2026, 02:41 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
try_indexed_search) could run when--crlfis enabled, butSearchQueryhas no CRLF-aware flag, allowing indexed providers to incorrectly omit candidate files and cause false-negative matches for patterns likeneedle$on CRLF files.Description
|| opts.crlfto the early-return conditions intry_indexed_searchincrates/bashkit/src/builtins/rg/mod.rs.test_rg_crlf_skips_indexed_prefilter_and_falls_back_to_linear_scanthat constructs anIndexedTestFswith no index matches and verifiesrg --crlf 'needle$'still finds the CRLF-terminated line via the linear scan.rgoutput for the linear path (needle\r\n).Testing
cargo test -p bashkit test_rg_crlf_skips_indexed_prefilter_and_falls_back_to_linear_scan -- --nocapture, which initially surfaced the failing expectation and then passed after the assertion fix.Codex Task