fix(rg): clear explicit line-number state on negation#1750
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | c9cb190 | Commit Preview URL | May 25 2026, 02:37 AM |
Earlier explicit --line-number / -n left line_numbers_explicit sticky through -N / --no-line-number negations, so '-n -N --column --no-column' incorrectly kept line numbers in output. Real rg clears the explicit request when the user negates it. Clear opts.line_numbers_explicit on --no-line-number and on short -N in combined-flag handling. Add regression tests for both short and long forms. Rebased on current main; original PR #1750 by chaliy.
chaliy
force-pushed
the
2026-05-25-fix-rg-line-number-negation-handling
branch
from
83ca841 to
320e495
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
rgoption parsing where an earlier explicit--line-number/-nremained sticky vialine_numbers_explicit, causing-n -N --column --no-columnto incorrectly keep line numbers.rgsemantics where a negation (--no-line-number/-N) clears the explicit request state.Description
opts.line_numbers_explicitwhen parsing--no-line-numberin the long-flag branch of the parser (crates/bashkit/src/builtins/rg/mod.rs).opts.line_numbers_explicitwhen parsing short-Nin the combined-short-flag handling in the same file.-n -N --column --no-columnand--line-number --no-line-number --column --no-columnto ensure final output omits line-number prefixes.Testing
cargo test -p bashkit test_rg_no_line_number_clears_explicit_state -- --nocaptureand the two new tests passed.Codex Task