Skip to content

fix(rg): keep parent dot-ignore active for --no-ignore-vcs#1746

Merged
chaliy merged 1 commit into
mainfrom
2026-05-25-fix-no-ignore-vcs-behavior-for-parent-ignores
May 25, 2026
Merged

fix(rg): keep parent dot-ignore active for --no-ignore-vcs#1746
chaliy merged 1 commit into
mainfrom
2026-05-25-fix-no-ignore-vcs-behavior-for-parent-ignores

Conversation

@chaliy
Copy link
Copy Markdown
Contributor

@chaliy chaliy commented May 25, 2026

Motivation

  • Fix incorrect semantics where --no-ignore-vcs also disabled parent ignore loading, causing parent .ignore/.rgignore to be skipped for child-root searches which diverges from real ripgrep behavior.

Description

  • Stop setting opts.no_ignore_parent when parsing --no-ignore-vcs so parent non‑VCS ignore files remain honored (change in crates/bashkit/src/builtins/rg/mod.rs).
  • Add a regression assertion to test_rg_parent_ignore_files that rg --no-ignore-vcs needle /proj/sub still honors the parent .ignore while disabling parent .gitignore.

Testing

  • Ran cargo test -p bashkit test_rg_parent_ignore_files -- --nocapture and the test passed.
  • Ran package tests via cargo test during validation and observed no test failures in the executed test run.

Codex Task

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 25, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
bashkit 5cf47b6 Commit Preview URL May 25 2026, 02:32 AM

@chaliy chaliy merged commit 99e0e1f into main May 25, 2026
34 checks passed
@chaliy chaliy deleted the 2026-05-25-fix-no-ignore-vcs-behavior-for-parent-ignores branch May 25, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant