fix(rg): bound ignore rule parsing and traversal memory#1745
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 9a4d086 | Commit Preview URL | May 25 2026, 02:30 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
rgignore-file support parsed unbounded.ignore/.gitignorecontent into compiled regex rules and cloned full rule vectors per-directory, enabling CPU/memory amplification from attacker-controlled repositories.Description
RG_IGNORE_FILE_MAX_BYTES(1 MiB),RG_IGNORE_RULES_MAX_PER_FILE(10,000), andRG_IGNORE_RULES_MAX_TOTAL(50,000) and return clearrg:execution errors when exceeded.parse_rg_ignore_rulesand file-size / total-rule checks inload_optional_ignore_file.Arc<Vec<RgIgnoreRule>>inRgWalkItemand only materializing a mutableVecwhen loading local rules for a directory.rg_rejects_too_many_ignore_rules_per_fileandrg_rejects_oversized_ignore_filesto cover the two exhaustion vectors.Testing
cargo fmt --allsuccessfully.cargo test -p bashkit rg_rejects_too_many_ignore_rules_per_fileand it passed.cargo test -p bashkit rg_rejects_oversized_ignore_filesand it passed.Codex Task