fix(rg): avoid quadratic glob toggle recompilation#1744
Merged
chaliy merged 1 commit intoMay 25, 2026
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | a3fc999 | Commit Preview URL | May 25 2026, 02:29 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
--glob-case-insensitive/--no-glob-case-insensitiveflags would recompile all prior non---iglobglobs on each toggle, causing O(n^2) work and a potential CPU DoS during synchronous argument parsing.Description
set_glob_case_insensitivecalls while iterating arguments and instead only flip theopts.glob_case_insensitivestate during parsing.opts.set_glob_case_insensitive(opts.glob_case_insensitive)?;, ensuring each non-iglobrule is recompiled at most once.Testing
cargo test -p bashkit test_rg_real_rg_diff -- --nocapture, which compiled and executed the rg differential tests without error (tests completed successfully).Codex Task