fix(rg): match binary json output#1737
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | cb5c214 | Commit Preview URL | May 25 2026, 12:28 AM |
chaliy
force-pushed
the
2026-05-24-rg-next-parity-batch
branch
3 times, most recently
from
cb981c4 to
7da5a51
Compare
chaliy
force-pushed
the
2026-05-24-rg-next-parity-batch
branch
from
7da5a51 to
cb5c214
Compare
chaliy
added a commit
that referenced
this pull request
May 25, 2026
Verify default-mode 'binary file matches ...' reporting: - explicit binary file argument - binary stdin Main already implements input.explicit handling differently than the original PR proposed (using a bool field rather than skip_binary_by_default); the meaningful contribution is the regression coverage. Rebased on current main; original PR #1756 by chaliy (refactor portion superseded by #1737).
chaliy
added a commit
that referenced
this pull request
May 25, 2026
#1756) Adds regression coverage to `test_rg_binary_text_modes` for the default-mode "binary file matches ..." reporting path: explicit binary file argument and binary stdin. The refactor portion of the original PR is superseded by main's `RgInput::explicit` design (#1737); this commit captures the meaningful behavioral regression coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Match real rg JSON behavior for binary files.
Why
Real rg does not emit human binary-match summaries in
--jsonmode. It emits JSON match/end events, setsbinary_offset, and treats NUL bytes as record breaks unless--textis set.How
binary_offseton end events.Risk
Checklist