Skip to content

Add redacted local activity summaries#112

Merged
haasonsaas merged 1 commit intomainfrom
codex/url-redaction-activity-20260502
May 3, 2026
Merged

Add redacted local activity summaries#112
haasonsaas merged 1 commit intomainfrom
codex/url-redaction-activity-20260502

Conversation

@haasonsaas
Copy link
Copy Markdown
Contributor

Summary

  • redact OAuth/auth query values from persisted document paths before local batch storage
  • add agentd activity --since HOURS --batch-dir PATH for JSON summaries of local batches by app/window/drop reason
  • redact sensitive URL query values again while summarizing older persisted JSON batches

Verification

  • swift test
  • swift build -Xswiftc -warnings-as-errors
  • swift-format lint --strict --recursive Sources Tests Package.swift
  • python3 scripts/mock_chronicle.py --self-test Tests/Fixtures/chronicle
  • git diff --check
  • scripts/package_app.sh
  • installed patched app via scripts/permission_smoke.sh
  • /Applications/EvalOps agentd.app/Contents/MacOS/agentd selftest
  • /Applications/EvalOps agentd.app/Contents/MacOS/agentd activity --since 1

@cursor
Copy link
Copy Markdown

cursor Bot commented May 3, 2026

PR Summary

Medium Risk
Adds a new diagnostic command that reads local batch JSON and changes document-path handling in the capture pipeline to redact sensitive URL components before persistence; mistakes here could impact on-disk privacy guarantees and diagnostic accuracy.

Overview
Adds a new agentd activity diagnostic command that summarizes locally persisted JSON batches over a time window (--since, --batch-dir), aggregating counts by app/window and drop reasons.

Introduces URLPrivacyRedactor and updates the capture pipeline to redact sensitive URL query/fragment values in documentPath before secret-scanning and before persisting frames, plus re-redacts documentPath when summarizing older stored batches. decodeSubmitBatchRequest is made non-private to support reading persisted batches, and new tests cover CLI parsing, summary aggregation, and URL redaction behavior.

Reviewed by Cursor Bugbot for commit 3b8e73e. Bugbot is set up for automated code reviews on this repo. Configure here.

@haasonsaas haasonsaas merged commit 6d128b9 into main May 3, 2026
4 checks passed
@haasonsaas haasonsaas deleted the codex/url-redaction-activity-20260502 branch May 3, 2026 03:05
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is ON, but it could not run because the branch was deleted or merged before autofix could start.

Reviewed by Cursor Bugbot for commit 3b8e73e. Configure here.

Comment thread Sources/agentd/ActivitySummary.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant