Skip to content

Remove redundant c_str() in set_path call

db2225b
Select commit
Loading
Failed to load commit list.
Merged

Optimize per-request critical path performance #365

Remove redundant c_str() in set_path call
db2225b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 11, 2026 in 1s

70.56% (+0.02%) compared to 42e769c

View this Pull Request on Codecov

70.56% (+0.02%) compared to 42e769c

Details

Codecov Report

❌ Patch coverage is 57.27273% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.56%. Comparing base (42e769c) to head (db2225b).
⚠️ Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
src/webserver.cpp 52.85% 8 Missing and 25 partials ⚠️
src/http_utils.cpp 57.89% 0 Missing and 8 partials ⚠️
src/string_utilities.cpp 54.54% 0 Missing and 5 partials ⚠️
src/httpserver/http_request.hpp 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #365      +/-   ##
==========================================
+ Coverage   70.54%   70.56%   +0.02%     
==========================================
  Files          28       28              
  Lines        1436     1488      +52     
  Branches      570      592      +22     
==========================================
+ Hits         1013     1050      +37     
- Misses         35       43       +8     
- Partials      388      395       +7     
Files with missing lines Coverage Δ
src/http_request.cpp 70.94% <100.00%> (+0.55%) ⬆️
src/httpserver/details/modded_request.hpp 100.00% <ø> (ø)
src/httpserver/http_request.hpp 88.37% <88.88%> (+4.16%) ⬆️
src/string_utilities.cpp 72.72% <54.54%> (+3.49%) ⬆️
src/http_utils.cpp 66.82% <57.89%> (+3.51%) ⬆️
src/webserver.cpp 57.42% <52.85%> (-1.39%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42e769c...db2225b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.