-
Notifications
You must be signed in to change notification settings - Fork 84
Updates to infrastructure monitor form #7240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Updates to infrastructure monitor form #7240
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
…the-LLM-toggle-in-the-monitor-creation-modal
Greptile SummaryThis PR implements UI improvements for infrastructure monitor forms by addressing three key areas: hiding LLM classification options for infrastructure monitors (which don't use classification), ensuring sensitive multiline fields use password inputs instead of textareas, and updating terminology from "SSO" to the more accurate "identity provider." Key Changes:
Issues Found:
Confidence Score: 4/5
Important Files Changed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5 files reviewed, 2 comments
clients/admin-ui/src/features/integrations/configure-monitor/ConfigureMonitorForm.tsx
Outdated
Show resolved
Hide resolved
| <InfoText> | ||
| <strong>Authentication:</strong> Okta integration uses OAuth2 Client | ||
| Credentials with private_key_jwt for secure authentication. You'll | ||
| need to create an API Services application in Okta and generate an RSA key | ||
| pair. | ||
| </InfoText> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lucanovera this looks like a duplicate of the section above it. Did you mean to remove it at some point or maybe it was a merge conflict?
| @@ -0,0 +1,4 @@ | |||
| type: Changed # One of: Added, Changed, Developer Experience, Deprecated, Docs, Fixed, Removed, Security | |||
| description: Updated infrastructure monitor form to not show classification options, use a password input for the key and a consistent wording. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| description: Updated infrastructure monitor form to not show classification options, use a password input for the key and a consistent wording. | |
| description: Updated infrastructure monitor form to not show classification options, use a password input for the key, and use consistent wording. |
Ticket ENG-2387 ENG-2394
Description Of Changes
Hides LLM toggle for infrastructure monitors. Updates text to say "Identity provider" instead of "SSO". Makes sensitive fields always use a password input, even when multiline.
Note: We don't have a component that supports password-like behavior and multiline like a Textarea. As a compromise for now, I think it's more important that we hide the sensitive information during creation, so an Input.Password will be used.
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works