Skip to content

Conversation

@lucanovera
Copy link
Contributor

@lucanovera lucanovera commented Jan 16, 2026

Ticket ENG-2387 ENG-2394

Description Of Changes

Hides LLM toggle for infrastructure monitors. Updates text to say "Identity provider" instead of "SSO". Makes sensitive fields always use a password input, even when multiline.

Note: We don't have a component that supports password-like behavior and multiline like a Textarea. As a compromise for now, I think it's more important that we hide the sensitive information during creation, so an Input.Password will be used.

Code Changes

Steps to Confirm

  1. Open preview link and enable the flags "Okta monitor" and "Helios v2"
  2. Go to integrations page and try to add an Okta monitor
  3. Check the "Private Key" field of the form shows a password type input that is hidden by default
  4. Check the info box at the top of the form says "Identity providers manage..."
  5. Go to an Okta integration detail page and check the description starts with "Identity providers manage.."
  6. Go to the Data discovery and try to add a monitor
  7. Check the Use LLM toggle is not present on the add monitor form, but you can still add the monitor

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Contributor

vercel bot commented Jan 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Jan 16, 2026 4:47pm
1 Skipped Deployment
Project Deployment Review Updated (UTC)
fides-privacy-center Ignored Ignored Jan 16, 2026 4:47pm

Request Review

@lucanovera lucanovera marked this pull request as ready for review January 16, 2026 16:36
@lucanovera lucanovera requested a review from a team as a code owner January 16, 2026 16:36
@lucanovera lucanovera requested review from gilluminate and removed request for a team January 16, 2026 16:36
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 16, 2026

Greptile Summary

This PR implements UI improvements for infrastructure monitor forms by addressing three key areas: hiding LLM classification options for infrastructure monitors (which don't use classification), ensuring sensitive multiline fields use password inputs instead of textareas, and updating terminology from "SSO" to the more accurate "identity provider."

Key Changes:

  • FormFieldFromSchema.tsx now prioritizes password input over textarea for sensitive fields, even when multiline is true
  • ConfigureMonitorForm.tsx conditionally hides the LLM classifier toggle for infrastructure monitors (currently only Okta)
  • Updated all user-facing text to use "identity provider" instead of "SSO" for consistency and accuracy

Issues Found:

  • Typo in changelog: "consitent" should be "consistent"
  • The logic for identifying infrastructure monitors (integrationOption.identifier === ConnectionType.OKTA) is duplicated across the codebase, though a centralized getMonitorType utility already exists for this purpose

Confidence Score: 4/5

  • This PR is safe to merge with minimal risk
  • The changes are straightforward UI improvements with clear requirements. A minor typo in the changelog and an opportunity to use existing utilities slightly reduces the score, but these are non-blocking issues. The core logic changes are sound and address the stated requirements effectively
  • Pay attention to ConfigureMonitorForm.tsx - while the implementation works, consider refactoring to use the existing getMonitorType utility for better maintainability

Important Files Changed

Filename Overview
changelog/infra-form-updates.yaml Changelog entry documenting form updates with typo in description
clients/admin-ui/src/features/common/form/FormFieldFromSchema.tsx Updated to prioritize password input over textarea for sensitive multiline fields
clients/admin-ui/src/features/integrations/configure-monitor/ConfigureMonitorForm.tsx Added logic to hide LLM classifier toggle for infrastructure monitors

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

Comment on lines 34 to 39
<InfoText>
<strong>Authentication:</strong> Okta integration uses OAuth2 Client
Credentials with private_key_jwt for secure authentication. You&apos;ll
need to create an API Services application in Okta and generate an RSA key
pair.
</InfoText>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucanovera this looks like a duplicate of the section above it. Did you mean to remove it at some point or maybe it was a merge conflict?

@@ -0,0 +1,4 @@
type: Changed # One of: Added, Changed, Developer Experience, Deprecated, Docs, Fixed, Removed, Security
description: Updated infrastructure monitor form to not show classification options, use a password input for the key and a consistent wording.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Updated infrastructure monitor form to not show classification options, use a password input for the key and a consistent wording.
description: Updated infrastructure monitor form to not show classification options, use a password input for the key, and use consistent wording.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants