-
Notifications
You must be signed in to change notification settings - Fork 84
Change request/ID verification flow to use separate pages instead of a modal #7238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Greptile SummaryConverted the privacy request flow from a modal-based approach to dedicated full-page routes ( Key Changes:
Minor Style Issues:
Confidence Score: 4/5
Important Files Changed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
13 files reviewed, 2 comments
| }} | ||
| data-testid={dataTestId} | ||
| > | ||
| <div style={{ width: "100%", maxWidth, padding: "48px 24px" }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: uses div instead of semantic components - per coding standards, prefer Ant Design's Flex component or other semantic elements
| <div style={{ width: "100%", maxWidth, padding: "48px 24px" }}> | |
| <Flex style={{ width: "100%", maxWidth, padding: "48px 24px" }}> |
Context Used: Rule from dashboard - Avoid using div elements when possible. Use semantic HTML elements or component library alternativ... (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| <div | ||
| style={{ | ||
| backgroundColor: "white", | ||
| padding: "48px", | ||
| width: "100%", | ||
| borderRadius: "4px", | ||
| boxShadow: | ||
| "0 1px 3px 0 rgba(0, 0, 0, 0.1), 0 1px 2px 0 rgba(0, 0, 0, 0.06)", | ||
| }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: uses div for form container - prefer semantic or Flex component
| <div | |
| style={{ | |
| backgroundColor: "white", | |
| padding: "48px", | |
| width: "100%", | |
| borderRadius: "4px", | |
| boxShadow: | |
| "0 1px 3px 0 rgba(0, 0, 0, 0.1), 0 1px 2px 0 rgba(0, 0, 0, 0.06)", | |
| }} | |
| <Flex | |
| style={{ | |
| backgroundColor: "white", | |
| padding: "48px", | |
| width: "100%", | |
| borderRadius: "4px", | |
| boxShadow: | |
| "0 1px 3px 0 rgba(0, 0, 0, 0.1), 0 1px 2px 0 rgba(0, 0, 0, 0.06)", | |
| }} | |
| > |
Context Used: Rule from dashboard - Avoid using div elements when possible. Use semantic HTML elements or component library alternativ... (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Ticket ENG-2283
Description Of Changes
Converted the privacy request flow from a modal-based approach to full-page routes. The form, verification, and success states now use dedicated Next.js pages with a consistent layout. Refactored ExternalAuthLayout to use a shared AuthFormLayout component to reduce code duplication.
Code Changes
ExternalAuthLayoutto useAuthFormLayoutinstead of duplicating layout codeSteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works