-
Notifications
You must be signed in to change notification settings - Fork 84
ENG-2404: Update CSP headers to include docs pages #7235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Greptile SummaryThis PR adds Content Security Policy (CSP) headers for the Changes include:
The implementation correctly whitelists the necessary external resources (scripts, styles, fonts, images) required for each documentation page to render properly while maintaining security through CSP. Confidence Score: 5/5
Important Files Changed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, 1 comment
|
@gretile pls rereview |
|
@greptile pls rereview |
Ticket ENG-2404
Description Of Changes
Updates CSP header definitions to include docs pages. These were broken when
FIDES__SECURITY__HEADER_MODEwas set torecommended.The changes include domains for scripts, styles, and images that are required for the respective page to load.
Code Changes
/docs/redocSteps to Confirm
FIDES__SECURITY__HEADER_MODE=recommended/docsmake sure the page loads and the console doesn't log any CSP errors/redocmake sure the page loads and the console doesn't log any CSP errorsPre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works