-
Notifications
You must be signed in to change notification settings - Fork 84
Add FidesLocaleUpdated event to monitor locale changes and improve documentation #7234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add FidesLocaleUpdated event to monitor locale changes and improve documentation #7234
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
0458ed8 to
0f19917
Compare
40c3980 to
3d43f5b
Compare
3d43f5b to
3539ba4
Compare
| window.Fides.locale = bestLocale; | ||
| setFidesGlobal(window.Fides as InitializedFidesGlobal); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This got missed when we first implemented the min/full experience split on TCF.
5de2f2e to
c1324ab
Compare
Greptile SummaryThis PR adds a new Key changes:
Confidence Score: 5/5
Important Files Changed
|
Description
Previously, the recommended pattern would result in the modal link label not updating when users changed their language preference. Adds
FidesLocaleUpdatedevent to support this. UpdatedgetModalLinkLabel()documentation and implementation to properly handle locale changes.Even though "fides-modal-link" has always been our default value for
modalLinkID, it never showed up that way inFides.options. This PR also updates the way we set that default to be more accessible to customers.Code Changes
FidesLocaleUpdatedevent that fires when locale changesLanguageSelectorcomponent to dispatch locale change eventsmodalLinkIdtype fromstring | nulltostringwith default valueTicket
ENG-1780
Steps to Confirm
http://localhost:3001/fides-js-demo.htmlFidesLocaleUpdatedevent logs