Skip to content

Conversation

@thabofletcher
Copy link
Contributor

@thabofletcher thabofletcher commented Jan 15, 2026

Ticket ENG-2285

Description Of Changes

Adds an alpha feature flag alphaDataProtectionAssessments to enable the Data Protection Assessments feature for managing DPAs and PIAs. This flag is:

  • Enabled by default in development environment
  • Disabled in test and production environments
  • Can be toggled in the UI at Settings > About (alpha page)

Code Changes

  • Added alphaDataProtectionAssessments flag to clients/admin-ui/src/flags.json

Steps to Confirm

  1. Start the admin-ui in development mode
  2. Log in and navigate to Settings > About (via /settings/about/alpha)
  3. Verify the "Alpha data protection assessments" toggle appears in the Alpha flags section
  4. Toggle the flag on/off and verify the value persists through page refresh

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • No UX review needed
  • Followup issues:
    • No followup issues
  • Database migrations:
    • No migrations
  • Documentation:
    • No documentation updates required

@vercel
Copy link
Contributor

vercel bot commented Jan 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Review Updated (UTC)
fides-plus-nightly Ignored Ignored Preview Jan 16, 2026 9:11pm
fides-privacy-center Ignored Ignored Jan 16, 2026 9:11pm

Request Review

@thabofletcher thabofletcher force-pushed the ENG-2285-data-protection-assessments-feature-flag branch from 33436ca to ee77a05 Compare January 16, 2026 20:31
@thabofletcher thabofletcher marked this pull request as ready for review January 16, 2026 21:05
@thabofletcher thabofletcher requested a review from a team as a code owner January 16, 2026 21:05
@thabofletcher thabofletcher requested review from lucanovera and removed request for a team January 16, 2026 21:05
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 16, 2026

Greptile Summary

This PR adds the alphaDataProtectionAssessments feature flag to enable the Data Protection Assessments feature in the admin-ui for managing DPAs and PIAs. The flag follows the established pattern for alpha features, enabled only in development and configurable via the Settings > About alpha page.

Changes Made

  • Added flag definition in clients/admin-ui/src/flags.json with appropriate environment settings (enabled in development, disabled in test/production)
  • Created changelog entry in changelog/7232.yaml documenting the addition
  • Flag naming, structure, and description are consistent with the existing alphaPrivacyNoticesSandbox pattern
  • No code changes needed - the infrastructure automatically supports flag toggle in the UI via the existing FlagControl component

Implementation Notes

  • The flag will automatically appear in the alpha features section of Settings > About once the UI calls useFlags() hook
  • Flag state persists across browser sessions via Redux persistence
  • No other code modifications required as the framework handles flag consumption through the standard useFlags() hook pattern

Confidence Score: 5/5

  • This PR is safe to merge with no identified issues.
  • This is a minimal, low-risk PR that adds a single feature flag definition. The change is purely declarative (JSON configuration) with no logic modifications. The flag follows established patterns in the codebase, uses consistent naming conventions with existing alpha flags, and is properly documented. The infrastructure to support this flag already exists and requires no code changes. Changelog entry is complete and properly formatted.
  • No files require special attention

Important Files Changed

Filename Overview
changelog/7232.yaml Changelog entry for the alpha feature flag addition. Entry is properly formatted with type, description, and PR number. No issues identified.
clients/admin-ui/src/flags.json Added alphaDataProtectionAssessments flag following the existing pattern. Configuration correctly sets the flag as enabled in development only, disabled in test and production. Naming convention, descriptions, and structure are consistent with existing alpha flags like alphaPrivacyNoticesSandbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants