Skip to content

Conversation

@lucanovera
Copy link
Contributor

@lucanovera lucanovera commented Jan 15, 2026

Ticket ENG-2392 ENG-2395 ENG-2390

Description Of Changes

Refactors layout and navigation of the infrastructure page to be consistent with other action center pages. Fixes infinite loop in results page. Adds a functional activity tab.

Code Changes

Steps to Confirm

  1. Visit preview link
  2. Enable the flags "Helios v2" and "Okta monitor"
  3. Visit okta monitor results page
  4. Check that the header shows an horizontal nav with 2 options: Attention required and Activity
  5. Clicking activity tab should navigate you although you probably won't see any results
  6. Check the "complete" filter option from the filter dropdown and click Apply
  7. It should now show at least 1 "Completed" monitor run for the monitor
  8. Try using the main navigation to go to any other page in Fides and check that both the url and the screen updates correctly

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Contributor

vercel bot commented Jan 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Jan 15, 2026 4:31pm
1 Skipped Deployment
Project Deployment Review Updated (UTC)
fides-privacy-center Ignored Ignored Jan 15, 2026 4:31pm

Review with Vercel Agent

@lucanovera lucanovera marked this pull request as ready for review January 15, 2026 16:18
@lucanovera lucanovera requested a review from a team as a code owner January 15, 2026 16:18
@lucanovera lucanovera requested review from speaker-ender and removed request for a team January 15, 2026 16:18
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 15, 2026

Greptile Summary

Refactors the infrastructure monitor page to use ActionCenterLayout and adds a functional activity tab, matching the pattern used by datastore monitors. The changes include extracting navigation logic to the shared layout component, fixing an infinite render loop caused by unstable default array references in filter hooks, and removing redundant UI elements from the table component.

Key changes:

  • Refactored infrastructure monitor pages to use shared ActionCenterLayout component for consistent navigation
  • Added new activity page for infrastructure monitors showing InProgressMonitorTasksList
  • Fixed infinite re-render bug by using stable default array references in useInfrastructureSystemsFilters
  • Removed duplicate navigation and title from DiscoveredInfrastructureSystemsTable (now handled by layout)
  • Added missing route constants for infrastructure monitor paths

Issues found:

  • Missing heliosV2 feature flag validation in both infrastructure monitor pages (main and activity). Datastore monitors include this check to prevent unauthorized access.

Confidence Score: 4/5

  • Safe to merge after adding feature flag validation to prevent unauthorized access
  • The refactoring follows established patterns from datastore monitors and successfully fixes the infinite render loop. However, both new infrastructure monitor pages are missing the heliosV2 feature flag check that the datastore equivalents include, which could allow unauthorized access to these pages
  • Both infrastructure monitor pages (index.tsx and activity/index.tsx) need the heliosV2 feature flag check added

Important Files Changed

Filename Overview
clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/useInfrastructureSystemsFilters.ts Fixed infinite re-render by using stable default array references
clients/admin-ui/src/pages/data-discovery/action-center/infrastructure/[monitorId]/activity/index.tsx New activity page for infrastructure monitors, following datastore pattern
clients/admin-ui/src/pages/data-discovery/action-center/infrastructure/[monitorId]/index.tsx Refactored to use ActionCenterLayout, following datastore pattern, but missing heliosV2 feature flag check

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6 files reviewed, 4 comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants