-
Notifications
You must be signed in to change notification settings - Fork 84
Show "powered by" brand link in modal/privacy center by default #7218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Greptile OverviewGreptile SummaryChanged the default value for
Confidence Score: 5/5
Important Files ChangedFile Analysis
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No files reviewed, no comments
lucanovera
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected, showing the brand is the default but you can still turn it off. Approved!
Ticket ENG-2337
Description Of Changes
Changes Fides brand link in CMP modal and privacy center to be enabled by default rather than dependent on env variable.
Steps to Confirm
FIDES_PRIVACY_CENTER__SHOW_BRAND_LINKfrom your .envFIDES_PRIVACY_CENTER__SHOW_BRAND_LINK=falseto your .envPre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works