add websocket support #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
naps62
reviewed
Jan 5, 2026
Member
naps62
left a comment
naps62
left a comment
There was a problem hiding this comment.
other than the minor comments, this looks good to go 👍
naps62
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Some of the services that compose a stack have interaction that work with websockets , for example subscription on the anvil nodes
How
Add a condition on the proxy controller to check if its a websocket upgrade , if it is then we use the
websock_adapterfunctions to upgrade the connection to awebsockconnection.We take that new connection with the target service and we forward the frames to it using the
gunclient , on thewebSocketProxymodule.We added some simple tests to check that a simple message, multiple messages and connection failure are handled gracefully.