Skip to content

Use find when lowering key security #2622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yorickdowne wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use find when lowering key security #2622

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions web3signer/convert-keys.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ fi
while true; do
echo "WARNING: This function will reduce the security of validator keys loaded into Web3signer."
echo "Web3signer startup time for thousands of keys will reduce to seconds."
echo "Conversion can take 30 minutes for 15,000 keys. Running in screen or tmux is recommended."
echo "Conversion can take an hour for 15,000 keys. Running in screen or tmux is recommended."
read -rp "Are you sure you want to convert keystores to lower security? (No/yes) " yn
case "${yn}" in
[Yy][Ee][Ss]) echo; break;;
Expand All @@ -40,15 +40,15 @@ while true; do
done

mkdir -p -m 700 "${base_dir}"/keys-backup."${ts}"
cp -rp "${base_dir}"/keys/* "${base_dir}"/keys-backup."${ts}"/
find "${base_dir}"/keys/ -maxdepth 1 -mindepth 1 -exec cp -rp -t "${base_dir}"/keys-backup."${ts}"/ {} +

for file in "${base_dir}"/keys-backup."${ts}"/*.password; do
[ -e "$file" ] || continue
cp -- "$file" "${file%.password}.txt"
done

/opt/converter/bin/converter --src="${base_dir}"/keys-backup."${ts}" --password-src="${base_dir}"/keys-backup."${ts}" --dest="${base_dir}"/converted-keys
cp "${base_dir}"/converted-keys/*.json "${base_dir}"/keys/
find "${base_dir}"/converted-keys/ -maxdepth 1 -name '*.json' -type f -exec cp -t "${base_dir}"/keys/ {} +

echo
echo "Original keys have been backed up to keys-backup.${ts}, inside the \"web3signer-keys\" Docker volume"
Expand Down
Loading