Skip to content

[codex] fix security alerts#706

Merged
barnabasbusa merged 1 commit into
masterfrom
codex/fix-security-alerts
May 21, 2026
Merged

[codex] fix security alerts#706
barnabasbusa merged 1 commit into
masterfrom
codex/fix-security-alerts

Conversation

@parithosh
Copy link
Copy Markdown
Member

Summary

Mirrors the workflow hardening landed in ethpandaops/assertoor#183.

  • Drops caller-controlled ref inputs from the reusable check/build workflows (_shared-check.yaml, _shared-build.yaml) so reusable jobs check out the event SHA instead of arbitrary PR-provided refs.
  • Moves the PR build workflow (build-dev.yml) from pull_request_target to pull_request and adds explicit read-only default permissions.
  • Splits PR binary builds from Docker publishing so fork PRs do not receive DockerHub secrets, while same-repository / manual trusted Docker publishing remains available.
  • Adds explicit permissions: contents: read to test-pr.yml, build-dev.yml, _shared-check.yaml, _shared-build.yaml, and _shared-docker-clone.yaml.
  • Switches internal artifact handoffs (ui-package, explorer_linux_amd64, explorer_linux_arm64) to artifact IDs to avoid artifact-name poisoning. Adds build_ui_package to the needs: list of the docker jobs that consume its artifact ID.

Validation

  • actionlint clean

🤖 Generated with Claude Code

Mirrors the workflow hardening from ethpandaops/assertoor#183:
- Drop caller-controlled ref inputs from reusable check/build workflows
- Move PR build trigger from pull_request_target to pull_request
- Add explicit read-only default permissions to workflows
- Split fork-PR binary builds from Docker publishing so secrets never reach untrusted code
- Switch internal artifact handoffs to artifact IDs to avoid name poisoning

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@barnabasbusa barnabasbusa merged commit 812d054 into master May 21, 2026
2 checks passed
@barnabasbusa barnabasbusa deleted the codex/fix-security-alerts branch May 21, 2026 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants