fix: NFT collection ZIP: nested folders, errors, gateway examples#135
Open
0xCardiE wants to merge 1 commit into
Open
fix: NFT collection ZIP: nested folders, errors, gateway examples#1350xCardiE wants to merge 1 commit into
0xCardiE wants to merge 1 commit into
Conversation
- Resolve images/ and json/ at any depth (e.g. build/images, build/json) - Skip __MACOSX junk; normalize paths; classify via nearest folder segment - Errors include sample ZIP paths and expected layout guidance - Post-upload section: clickable gateway URLs open in new tab - Tooltip notes parent-folder zips; error text wraps in UI
0xCardiE
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes and UX improvements for Upload NFT collection when the ZIP does not have
images/andjson/at the archive root (for example Hardhat-stylebuild/imagesandbuild/json). Also improves failure messaging and the success panel.Changes
NFTCollectionProcessor.ts\→/), ignore__MACOSXand.DS_Store.images/orjson/at any depth using the nearest qualifying folder segment before the filename (so zippingbuild/works).SwapComponent.tsx+SwapComponent.module.cssbuild/images,build/json).1.json/1.pngexamples).pre-wrap/overflow-wrap) for long diagnostics.How to verify
build/images/0.pngandbuild/json/0.json; upload with Upload NFT collection — processing should succeed.images/jsonfolders); confirm the error lists sample paths and explains the layout.