test: add integration testing for both v1 and v2 feeds #551
+507
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinconic
requested review from
akrem-chabchoub,
gacevicljubisa,
janos and
martinconic
martinconic
approved these changes
Dec 22, 2025
|
|
||
| batchID, err := upClient.GetOrCreateMutableBatch(ctx, o.PostageTTL, o.PostageDepth, o.PostageLabel) | ||
| if err != nil { | ||
| return err |
Contributor
There was a problem hiding this comment.
Should have custom error message like this ?
Also for other errors checks some of them doesn't contain custom message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re-adds the tests that were removed for v1 feeds. both integration tests are labeled as
feed-v1andmanifest-v1, wheremanifestandfeedtest v2 implicitly.