Skip to content

feat(nuker): optimize NukeByStatefulSets to preserve input order #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gacevicljubisa merged 1 commit into from
Oct 28, 2025
Merged

feat(nuker): optimize NukeByStatefulSets to preserve input order #542

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions pkg/nuker/nuker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,13 @@ func (c *Client) NukeByStatefulSets(ctx context.Context, namespace string, state
}

statefulSetsMap := make(map[string]*v1.StatefulSet)
var orderedNames []string

for _, name := range statefulSetNames {
if _, exists := statefulSetsMap[name]; exists {
continue
}

statefulSet, err := c.k8sClient.StatefulSet.Get(ctx, name, namespace)
if err != nil {
if k8serrors.IsNotFound(err) {
Expand All @@ -133,14 +138,24 @@ func (c *Client) NukeByStatefulSets(ctx context.Context, namespace string, state
}
return fmt.Errorf("failed to get stateful set %s: %w", name, err)
}

statefulSetsMap[name] = statefulSet
orderedNames = append(orderedNames, name)
}

c.log.Infof("found %d stateful sets to update", len(statefulSetsMap))
if len(orderedNames) == 0 {
c.log.Warning("no valid stateful sets found to update")
return nil
}

c.log.Infof("found %d stateful sets to update", len(orderedNames))

count := 0

for name, ss := range statefulSetsMap {
// iterate in the same order as the input statefulSetNames
for _, name := range orderedNames {
ss := statefulSetsMap[name]

if ss.Spec.Replicas == nil || *ss.Spec.Replicas == 0 {
c.log.Infof("skipping stateful set %s: no replicas", name)
continue
Expand Down