Skip to content

feat(pushsync): add rate limiting and metric for overdraft refresh logs #5297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gacevicljubisa merged 1 commit into from
Dec 2, 2025
Merged

feat(pushsync): add rate limiting and metric for overdraft refresh logs #5297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pkg/pushsync/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ type metrics struct {
ReceiptDepth *prometheus.CounterVec
ShallowReceiptDepth *prometheus.CounterVec
ShallowReceipt prometheus.Counter
OverdraftRefresh prometheus.Counter
}

func newMetrics() metrics {
Expand Down Expand Up @@ -146,6 +147,12 @@ func newMetrics() metrics {
},
[]string{"depth"},
),
OverdraftRefresh: prometheus.NewCounter(prometheus.CounterOpts{
Namespace: m.Namespace,
Subsystem: subsystem,
Name: "overdraft_refresh",
Help: "Total number of times peers were skipped due to overdraft, requiring a wait to refresh balance.",
}),
}
}

Expand Down
8 changes: 7 additions & 1 deletion pkg/pushsync/pushsync.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ import (
"github.com/opentracing/opentracing-go"
"github.com/opentracing/opentracing-go/ext"
olog "github.com/opentracing/opentracing-go/log"
"golang.org/x/time/rate"
)

// loggerName is the tree path name of the logger for this package.
Expand Down Expand Up @@ -99,6 +100,7 @@ type PushSync struct {
stabilizer stabilization.Subscriber

shallowReceiptTolerance uint8
overDraftRefreshLimiter *rate.Limiter
}

type receiptResult struct {
Expand Down Expand Up @@ -148,6 +150,7 @@ func New(
errSkip: skippeers.NewList(time.Minute),
stabilizer: stabilizer,
shallowReceiptTolerance: shallowReceiptTolerance,
overDraftRefreshLimiter: rate.NewLimiter(rate.Every(time.Second), 1),
}

ps.validStamp = ps.validStampWrapper(validStamp)
Expand Down Expand Up @@ -424,7 +427,10 @@ func (ps *PushSync) pushToClosest(ctx context.Context, ch swarm.Chunk, origin bo
continue // there is still an inflight request, wait for it's result
}

ps.logger.Debug("sleeping to refresh overdraft balance", "chunk_address", ch.Address())
ps.metrics.OverdraftRefresh.Inc()
if ps.overDraftRefreshLimiter.Allow() {
ps.logger.Debug("sleeping to refresh overdraft balance")
}

select {
case <-time.After(overDraftRefresh):
Expand Down
Loading