test: integrate synctest in access control pkg

[akrem-chabchoub]

Checklist

• I have read the coding guide.
• My change requires a documentation update, and I have done it.
• I have added tests to cover my changes.
• I have filled out the description and linked the related issues.

Description

Add synctest in controller_test.go

Open API Spec Version Changes (if applicable)

Motivation and Context (Optional)

Related Issue (Optional)

#5232

Screenshots (if appropriate):

[Copilot]

Pull request overview

This PR integrates synctest from the testing/synctest package into the access control test suite to enable deterministic time-based testing. The change wraps a test case that involves time-dependent behavior (adding and revoking access with historical timestamp lookups) in a synctest.Test wrapper.

Key Changes

• Added testing/synctest import to the test file
• Wrapped the "add and revoke then get from history" test case with synctest.Test() for controlled time advancement

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

When using synctest.Test, you should replace time.Sleep() calls with synctest.Wait() to properly utilize synctest's controlled time advancement. The current implementation wraps the test with synctest but still uses time.Sleep(), which defeats the purpose of using synctest.

Replace:

time.Sleep(1 * time.Second)

With:

synctest.Wait()

This pattern is used consistently in other parts of the codebase (e.g., pkg/blocker/blocker_test.go).

Suggested change

	time.Sleep(1 * time.Second)
	beforeRevokeTS := time.Now().Unix()
	_, egranteeRef, hrefUpdate1, _, err := c.UpdateHandler(ctx, ls, gls, swarm.ZeroAddress, hRef, &publisher.PublicKey, addRevokeList, nil)
	require.NoError(t, err)
	time.Sleep(1 * time.Second)
	synctest.Wait()
	beforeRevokeTS := time.Now().Unix()
	_, egranteeRef, hrefUpdate1, _, err := c.UpdateHandler(ctx, ls, gls, swarm.ZeroAddress, hRef, &publisher.PublicKey, addRevokeList, nil)
	require.NoError(t, err)
	synctest.Wait()

[Copilot]

When using synctest.Test, you should replace time.Sleep() calls with synctest.Wait() to properly utilize synctest's controlled time advancement. The current implementation wraps the test with synctest but still uses time.Sleep(), which defeats the purpose of using synctest.

Replace:

time.Sleep(1 * time.Second)

With:

synctest.Wait()

This pattern is used consistently in other parts of the codebase (e.g., pkg/blocker/blocker_test.go).

Suggested change

	time.Sleep(1 * time.Second)
	beforeRevokeTS := time.Now().Unix()
	_, egranteeRef, hrefUpdate1, _, err := c.UpdateHandler(ctx, ls, gls, swarm.ZeroAddress, hRef, &publisher.PublicKey, addRevokeList, nil)
	require.NoError(t, err)
	time.Sleep(1 * time.Second)
	synctest.Wait()
	beforeRevokeTS := time.Now().Unix()
	_, egranteeRef, hrefUpdate1, _, err := c.UpdateHandler(ctx, ls, gls, swarm.ZeroAddress, hRef, &publisher.PublicKey, addRevokeList, nil)
	require.NoError(t, err)
	synctest.Wait()

[akrem-chabchoub]

synctest.Wait() doesn't advance time, it only waits until all goroutines are blocked according to the official docs.
This test needs the virtual clock to actually advance so i kept the time.Sleep(). The comment on line 245 explains why.
So without time.Sleep() in this test, time.Now() returns the same value twice, causing an error.