test(puller): fix race condition in TestSyncIntervals #5277
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wait for interval persistence using spinlock.Wait() instead of fixed sleep. This fixes the flaky 'storage: not found' error in TestSyncIntervals/0,_50_-_2_calls by polling for the interval to appear in storage rather than checking immediately after sync operations complete. The test was failing because checkIntervals() was checking for persisted intervals immediately after sync calls completed, but interval persistence happens asynchronously. Using spinlock.Wait() makes the test more deterministic and handles timing variations better than a fixed time.Sleep().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Wait for interval persistence using spinlock.Wait() instead of fixed sleep. This fixes the flaky 'storage: not found' error in TestSyncIntervals/0,50-_2_calls by polling for the interval to appear in storage rather than checking immediately after sync operations complete.
The test was failing because checkIntervals() was checking for persisted intervals immediately after sync calls completed, but interval persistence happens asynchronously. Using spinlock.Wait() makes the test more deterministic and handles timing variations better than a fixed time.Sleep().
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):