feat(test-fill): align fill-stateful with gas-benchmarks implementation#2923
Open
LouisTsai-Csie wants to merge 5 commits into
Open
feat(test-fill): align fill-stateful with gas-benchmarks implementation#2923LouisTsai-Csie wants to merge 5 commits into
fill-stateful with gas-benchmarks implementation#2923LouisTsai-Csie wants to merge 5 commits into
Conversation
9 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2923 +/- ##
===================================================
- Coverage 90.44% 90.43% -0.01%
===================================================
Files 535 535
Lines 32439 32430 -9
Branches 3012 3012
===================================================
- Hits 29338 29329 -9
Misses 2573 2573
Partials 528 528
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Add a few features & refactors to the stateful filling implementation.
Commit d198221: Replace
debug_setHeadwith FCU approach.debug_setHeadonly supports in Geth, Besu and Erigon. Nethermind implementsdebug_resetHeadthat takes block hash as input. Reth has the method registered but not implemented (Link), Nimbus comments out the method (Link), no implementation either.Consider some features (e.g., built-in opcode tracing) is now only supported in Nethermind master branch, this PR changes the
debug_setHeadto FCU version, in order to set the canonical chain.Commit 0252bec: Add a new CLI flag
--gas-bump-blocks.For perf-devnet-3 snapshot, we need to bump the block gas limit to ~1T block gas limit. This is done by sending empty blocks in gas-benchmarks. User could use
--gas-bump-blocksto assign number of empty block to increase the block gas limit.In gas-benchmarks, we send 5000 empty blocks to bump the block gas limit for perf-devnet-3. For Jochmnet, we do not need to bump the gas limit, as the block gas limit is already high enough (~1 gigagas).
Commit 05f3c16: Add deterministic sender pooling.
For
test_ether_transfers_onchain_receiversbenchmark, to prevent the sender account being cached, we pre-fund the account via CL withdrawal. We inject 15K withdrawal into funding phase, starting with this pk range:Commit 54f43ad: Batch tx receipt request
Batch tx receipt RPC request, to avoid large amount of RPC request at the same time. This was a bottleneck in the past when using gas-benchmarks.
Commit 8477bfe: refactor
fill_stateful.pySplit the hive setup version from the original
fill_stateful.pyfile, to keep the file small and focus on the filler feature.These senders are then consumed by
test_ether_transfers_onchain_receivers, this aligns changes in gas-benchmarks PR NethermindEth/gas-benchmarks#146Verification
Verify the test via Hive mode, works successfully.
🔗 Related Issues or PRs
Issue #2910
✅ Checklist
just statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture