Skip to content

fix(specs): backport check_gas before state access boundaries from Amsterdam#2903

Draft
fselmo wants to merge 3 commits into
ethereum:forks/amsterdamfrom
fselmo:fix/check-gas-at-appropriate-boundaries
Draft

fix(specs): backport check_gas before state access boundaries from Amsterdam#2903
fselmo wants to merge 3 commits into
ethereum:forks/amsterdamfrom
fselmo:fix/check-gas-at-appropriate-boundaries

Conversation

@fselmo
Copy link
Copy Markdown
Contributor

@fselmo fselmo commented May 22, 2026

🗒️ Description

🔗 Related Issues or PRs

closes #1867

✅ Checklist

  • All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    just static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

Cute Animal Picture

Screenshot 2026-05-22 at 15 07 56

@fselmo fselmo force-pushed the fix/check-gas-at-appropriate-boundaries branch from 5d50695 to 304cf07 Compare May 22, 2026 20:38
@fselmo fselmo added A-spec-specs Area: Specification—The Ethereum specification itself (eg. `src/ethereum/*`) C-bug Category: this is a bug, deviation, or other problem C-refactor Category: refactor and removed C-bug Category: this is a bug, deviation, or other problem labels May 22, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

❌ Patch coverage is 90.37037% with 52 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.49%. Comparing base (810c184) to head (0a3f40e).
⚠️ Report is 3 commits behind head on forks/amsterdam.

Files with missing lines Patch % Lines
...ethereum/forks/byzantium/vm/instructions/system.py 33.33% 2 Missing and 2 partials ⚠️
...rc/ethereum/forks/amsterdam/vm/instructions/log.py 0.00% 1 Missing and 1 partial ⚠️
src/ethereum/forks/berlin/vm/instructions/log.py 0.00% 1 Missing and 1 partial ⚠️
...c/ethereum/forks/berlin/vm/instructions/storage.py 50.00% 1 Missing and 1 partial ⚠️
...rc/ethereum/forks/berlin/vm/instructions/system.py 95.74% 1 Missing and 1 partial ⚠️
...rc/ethereum/forks/byzantium/vm/instructions/log.py 0.00% 1 Missing and 1 partial ⚠️
...thereum/forks/byzantium/vm/instructions/storage.py 0.00% 1 Missing and 1 partial ⚠️
src/ethereum/forks/cancun/vm/instructions/log.py 0.00% 1 Missing and 1 partial ⚠️
...hereum/forks/constantinople/vm/instructions/log.py 0.00% 1 Missing and 1 partial ⚠️
...um/forks/constantinople/vm/instructions/storage.py 0.00% 1 Missing and 1 partial ⚠️
... and 15 more
Additional details and impacted files
@@                 Coverage Diff                 @@
##           forks/amsterdam    #2903      +/-   ##
===================================================
+ Coverage            90.44%   90.49%   +0.05%     
===================================================
  Files                  535      535              
  Lines                32439    32633     +194     
  Branches              3012     3063      +51     
===================================================
+ Hits                 29338    29532     +194     
  Misses                2573     2573              
  Partials               528      528              
Flag Coverage Δ
unittests 90.49% <90.37%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fselmo fselmo marked this pull request as ready for review May 22, 2026 20:50
@fselmo fselmo requested a review from SamWilsn May 22, 2026 21:11
@LouisTsai-Csie LouisTsai-Csie self-requested a review May 25, 2026 09:59
LouisTsai-Csie

This comment was marked as resolved.

@fselmo
Copy link
Copy Markdown
Contributor Author

fselmo commented May 26, 2026

Thanks for the first pass here @LouisTsai-Csie 🙏🏼. I just pushed a clean up here.

@fselmo
Copy link
Copy Markdown
Contributor Author

fselmo commented May 26, 2026

Worth addressing that this open question on ordering may change this design significantly: ethereum/EIPs@master...nerolation:EIPs:toni/state-access

So I'm putting this in draft until this is discussed. But this would be a good optimization to bake in imo.

@fselmo fselmo marked this pull request as draft May 26, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-spec-specs Area: Specification—The Ethereum specification itself (eg. `src/ethereum/*`) C-refactor Category: refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Track gas more appropriately prior to state access in specs

2 participants