Skip to content

fix(ci): devnet-7 linting issue#2884

Closed
LouisTsai-Csie wants to merge 4 commits into
ethereum:devnets/bal/7from
LouisTsai-Csie:devnet-7-linting
Closed

fix(ci): devnet-7 linting issue#2884
LouisTsai-Csie wants to merge 4 commits into
ethereum:devnets/bal/7from
LouisTsai-Csie:devnet-7-linting

Conversation

@LouisTsai-Csie
Copy link
Copy Markdown
Collaborator

🗒️ Description

I ran into several CI issue after rebasing my branch to upstream devnets/bal/7 branch:

Running just static produced three independent failures:

ethereum-spec-lint

ValueError: duplicate path Header.slot_number 
raised from src/ethereum_spec_tools/lint/lints/patch_hygiene.py:101

mypy

src/ethereum/forks/amsterdam/blocks.py:268: error: Name "slot_number"
already defined on line 260 [no-redef]`

packages/testing/src/execution_testing/specs/tests/test_types.py
lines 159/169/178/193/207:
"type[BuiltBlock]" has no attribute "derive_engine_payload_modifier"
[attr-defined]` (5 occurrences).

ruff format

tests/benchmark/compute/scenario/test_unchunkified_bytecode.py` would be reformatted.

Failures (1) and (2.a) share a root cause. Failure (2.b) shares a root cause with a different commit. Failure (3) is older and pre-existing.

this commit dffc4cf might be the root cause.

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    just static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@LouisTsai-Csie LouisTsai-Csie added C-bug Category: this is a bug, deviation, or other problem A-ci Area: Continuous Integration labels May 20, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (devnets/bal/7@0cd4522). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             devnets/bal/7    #2884   +/-   ##
================================================
  Coverage                 ?   87.35%           
================================================
  Files                    ?      586           
  Lines                    ?    35957           
  Branches                 ?     3382           
================================================
  Hits                     ?    31410           
  Misses                   ?     3926           
  Partials                 ?      621           
Flag Coverage Δ
unittests 87.35% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LouisTsai-Csie
Copy link
Copy Markdown
Collaborator Author

Close in favor of PR #2885

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ci Area: Continuous Integration C-bug Category: this is a bug, deviation, or other problem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants