feat(zkevm): add engine-witness simulator and add executionWitnessMutated flag into fixtures

[jsign]

🗒️ Description

This PR:

• Add support for uv run consume engine-witness simulator to allow running execution witness fixtures in Hive. This is based on feat(test-consume): add engine-witness simulator for witness verification #2724 with a couple of extra fixes needed to finish it.
• Add executionWitnessMutated boolean flag to fixtures (more about this below).

Regarding the last point: the existing executionWitness in fixtures signals the expected execution witness that a stateful-EL should create for the given fixture. This is similar to an "expected BAL" for the block.

But there is a catch: the execution witness isn't part of the execution payload for stateful-ELs; the execution witness is only used as input for the stateless validator.

We have many tests that mutate the correct execution witness for a block, so that we can check that the stateless validator fails when executing the block.

This means that:

• For fixtures that do not mutate the execution witness: the fixture should pass both for stateful and stateless execution clients.
• For fixtures that do mutate the execution witness to make them invalid: the fixture should fail for the stateless validator (since that was the goal of the test), but actually don't make sense to be run in stateful-ELs. Mostly because the mutation happens in the testing framework after the real filling was done, and as said, the execution witness isn't used at all as input in the stateful run so it won't fail.

This means that fixtures that perform execution-witness mutation shouldn't be run with uv run consume engine-witness, which targets only stateful-ELs, not stateless validator runs.

The way to handle this now is that I added an executionWitnessMutated field in the fixtures, so this can be noted. If it is true, then uv run consume engine-witness will skip them since those fixtures aren't really a target to test stateful-EL correctness in constructing an execution witness.

I've the feeling this situation is just adding a bit more to the tension of using blockchain_tests as a format. We have been pushing back a bit on a new fixture format to avoid complexity in the testing framework and the need for multiple ELs to support it. But at some point after some things settle, we can reconsider if maybe it is a good strategy. e.g. keep blockchain_tests for things that only make sense for stateful-ELs, and create a separate format for stateless runs, which would indirectly avoid needing this flag plus avoiding some current bloating of redundant data (in different encoding formats) in blockchain_tests. Created #2873 for tracking discussion.

🔗 Related Issues or PRs

N/A.

✅ Checklist

• All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:

  just static

• All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
• All: Considered updating the online docs in the ./docs/ directory.
• All: Set appropriate labels for the changes (only maintainers can apply labels).
• Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
• Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
• Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.24%. Comparing base (258c3c1) to head (b93bcd1).
⚠️ Report is 249 commits behind head on projects/zkevm.

Additional details and impacted files

@@                Coverage Diff                 @@
##           projects/zkevm    #2872      +/-   ##
==================================================
+ Coverage           85.72%   88.24%   +2.51%     
==================================================
  Files                 612      591      -21     
  Lines               37853    36832    -1021     
  Branches             3932     3675     -257     
==================================================
+ Hits                32451    32501      +50     
+ Misses               4652     3685     -967     
+ Partials              750      646     -104     

Flag	Coverage Δ
unittests	88.24% <ø> (+2.51%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Dyslex7c]

Could not find a part of the path '/var/folders/.../nethermind-eest/PyTests/tests-zkevm@v0.4.1/fixtures_zkevm/fixtures/blockchain_tests_engine/for_amsterdam/eip7928_block_level_access_lists will these be included in the next release? @jsign

[jsign]

@Dyslex7c, the blockchain_tests_engine are in the release:

is this what are you refering to?

[jsign]

@Dyslex7c, I think tehre is a missing folder in your path.

[Dyslex7c]

@Dyslex7c, I think tehre is a missing folder in your path.

right that fixed it, thanks