feat: Add EIP-7805 metrics #4
Conversation
development/osaka/eip-7805.md
Outdated
|
|
||
| | Name | Metric type | Usage | Sample collection event | Labels | Buckets | | ||
| |------|-------------|-------|-------------------------|--------|---------| | ||
| |`execution_inclusion_list_transactions_received_in_payload_total`| Counter | Total number of inclusion list transactions received in payload | On receiving payload | | | |
There was a problem hiding this comment.
This should be equal to beacon_inclusion_list_transactions_sent_to_payload_total, right?
development/osaka/eip-7805.md
Outdated
| |`execution_inclusion_list_transactions_valid_total`| Counter | Total number of valid inclusion list transactions | On inclusion list transactions validation | | | | ||
| |`execution_inclusion_list_transactions_invalid_total`| Counter | Total number of invalid inclusion list transactions | On inclusion list transactions validation | | | | ||
| |`execution_inclusion_list_transactions_validation_time_seconds`| Histogram | Time taken to validate inclusion list transactions | On inclusion list transactions validation | | | | ||
| |`execution_inclusion_list_unsatisfied_blocks_total`| Counter | Total number of unsatisfied inclusion list blocks | On inclusion list transactions validation | | | |
There was a problem hiding this comment.
This will be equal to beacon_inclusion_list_unsatisfied_blocks_total, right?
development/osaka/eip-7805.md
Outdated
| |------|-------------|-------|-------------------------|--------|---------| | ||
| |`execution_inclusion_list_transactions_received_in_payload_total`| Counter | Total number of inclusion list transactions received in payload | On receiving payload | | | | ||
| |`execution_inclusion_list_transactions_valid_total`| Counter | Total number of valid inclusion list transactions | On inclusion list transactions validation | | | | ||
| |`execution_inclusion_list_transactions_invalid_total`| Counter | Total number of invalid inclusion list transactions | On inclusion list transactions validation | | | |
There was a problem hiding this comment.
What do you think about adding metrics for gas and size? For example,
execution_inclusion_list_transactions_valid_size_bytes_total
execution_inclusion_list_transactions_invalid_size_bytes_total
execution_inclusion_list_transactions_valid_gas_usage_total
execution_inclusion_list_transactions_valid_gas_limit_total
execution_inclusion_list_transactions_invalid_gas_usage_total
execution_inclusion_list_transactions_invalid_gas_limit_total
There was a problem hiding this comment.
Also, what do you think about metrics for engine APIs such as:
execution_engine_getInclusionListV1_requests_total
execution_engine_getInclusionListV1_returned_inclusion_list_transactions (histogram)
2 participants
This PR introduces a new set of metrics to monitor the functionality and performance of EIP-7805 (FOCIL).