Skip to content

bump OpenRPC schema to 1.3#809

Open
bomanaps wants to merge 2 commits into
ethereum:mainfrom
bomanaps:bump-openrpc-to-1.4.x
Open

bump OpenRPC schema to 1.3#809
bomanaps wants to merge 2 commits into
ethereum:mainfrom
bomanaps:bump-openrpc-to-1.4.x

Conversation

@bomanaps
Copy link
Copy Markdown
Contributor

Bumps the OpenRPC spec version from 1.2.4 to 1.4.1 and swaps the deprecated open-rpc/meta-schema Go binding for the new open-rpc/spec-types v1_4 package, so we can start specifying notification methods (needed for eth_subscribe).

@bomanaps bomanaps changed the title bump OpenRPC schema to 1.4.1 bump OpenRPC schema to 1.3 May 25, 2026
@bomanaps
Copy link
Copy Markdown
Contributor Author

Went with 1.3.2 over 1.4.x because the docusaurus toolchain's JS validator
@open-rpc/meta-schema hasn't caught up to 1.4 yet, and 1.3 already supports
notification methods which is the actual blocker for eth_subscribe.

@zcstarr
Copy link
Copy Markdown
Contributor

zcstarr commented May 25, 2026

@bomanaps we don't use meta-schema for validation in typescript, we use https://github.com/open-rpc/schema-utils-js , if there's a stale dep we'll definitely update it, but the meta-schema is actually deprecated. Schema-utils doesn't use meta-schema under the hood, it uses https://github.com/open-rpc/spec-types.

I advise that you use 1.4.x , just because that chain is the latest head, and if there are patches that we need to do you won't pick those up on 1.3.x . Also it should be fully supported by all the tools, if you encountered thing that isn't, we'll patch it.

@bomanaps bomanaps closed this May 25, 2026
@bomanaps
Copy link
Copy Markdown
Contributor Author

@bomanaps we don't use meta-schema for validation in typescript, we use https://github.com/open-rpc/schema-utils-js , if there's a stale dep we'll definitely update it, but the meta-schema is actually deprecated. Schema-utils doesn't use meta-schema under the hood, it uses https://github.com/open-rpc/spec-types.

I advise that you use 1.4.x , just because that chain is the latest head, and if there are patches that we need to do you won't pick those up on 1.3.x . Also it should be fully supported by all the tools, if you encountered thing that isn't, we'll patch it.

If you can do the bump that will be great

Comment thread tools/internal/specgen/base-doc.json Outdated
@@ -1,5 +1,5 @@
{
"openrpc": "1.2.4",
"openrpc": "1.3.2",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"openrpc": "1.3.2",
"openrpc": "1.4.1",

Comment thread tools/internal/metaschema/metaschema.go Outdated
"strings"

openrpc "github.com/open-rpc/meta-schema"
openrpc "github.com/open-rpc/spec-types/generated/packages/go/v1_3"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
openrpc "github.com/open-rpc/spec-types/generated/packages/go/v1_3"
openrpc "github.com/open-rpc/spec-types/generated/packages/go/v1_4"

Comment thread tools/cmd/speccheck/spec.go Outdated
"os"

openrpc "github.com/open-rpc/meta-schema"
openrpc "github.com/open-rpc/spec-types/generated/packages/go/v1_3"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
openrpc "github.com/open-rpc/spec-types/generated/packages/go/v1_3"
openrpc "github.com/open-rpc/spec-types/generated/packages/go/v1_4"

Comment thread tools/cmd/speccheck/check.go Outdated
"strings"

openrpc "github.com/open-rpc/meta-schema"
openrpc "github.com/open-rpc/spec-types/generated/packages/go/v1_3"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
openrpc "github.com/open-rpc/spec-types/generated/packages/go/v1_3"
openrpc "github.com/open-rpc/spec-types/generated/packages/go/v1_4"

Copy link
Copy Markdown
Contributor

@zcstarr zcstarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just reopen this PR I made the version bump suggestions, that should be all that's required.

@zcstarr
Copy link
Copy Markdown
Contributor

zcstarr commented May 25, 2026

I think you're most of the way there here, just change the v1_3 to v1_4 . That's the only difference, just means that all the tooling around the spec will properly track changes.

@bomanaps bomanaps reopened this May 25, 2026
@bomanaps bomanaps force-pushed the bump-openrpc-to-1.4.x branch from de84fc1 to ef82cc7 Compare May 25, 2026 17:36
@bomanaps bomanaps requested a review from zcstarr May 26, 2026 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants