fix: byte and uintDecimal patterns fixed to match geth#802
Open
felix314159 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
two regex patterns in
src/schemas/base-types.yamldiverge from what geth actually does:byteOld pattern allows
"0x"but geth would always append at least one hex digit (e.g. to make it0x0in the smallest case)uintDecimalold pattern rejects
"0"but geth allows plain 0 (hereapi.networkVersionis justuint64and there is no guarding or whatever against0). i used this example cuz it is the JSON-emitter fornet_versionAFAIK all in-spec example values that resolve to these two types still validate without additional changes