Skip to content

Conversation

@Hiswe
Copy link
Contributor

@Hiswe Hiswe commented Apr 21, 2015

Hi,

I'v added the findKeys methods for being able to use the listAllPads methods of Etherpad.

Also the felix-couchdb was missing in the package.json.
And about felix-couchdb, it was also broken for me… so I made a pull request in order to make it work. Without this patch, this module will sadly throw errors 😞

@JohnMcLear
Copy link
Member

Afaik this should not be how it's done.

@Hiswe
Copy link
Contributor Author

Hiswe commented Apr 21, 2015

:S
I'm not a couchDB expert at all ¬_¬'
But I haven't seen any way to filter by a dynamic regexp in a design document…

I might look it further, but being in a hurry I can't do it right now.

@JohnMcLear
Copy link
Member

Adding findAllPads to the module is wrong. findAllPads is a method exclusive to Etherpad.

That logic needs to be in Etherpad and not ueberDB :) Make sense? Look at the other modules for ueberDB, you will see they don't contain findAllPads

@Hiswe
Copy link
Contributor Author

Hiswe commented Apr 21, 2015

You're right 👍
Trying to make Etherpad working, I haven't seen this huge flaw.
I really have to figure out to put a regexp in the design doc…

@Hiswe Hiswe closed this Apr 21, 2015
@Hiswe Hiswe deleted the fix/couch-db branch April 28, 2015 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants