docs(7538): soffice is now optional for docx/pdf#7707
Conversation
Native DOCX export, PDF export, and DOCX import shipped in #7568 via pure-JS in-process converters -- LibreOffice/soffice is no longer required for those formats. Stale comments in settings.json.template and settings.json.docker still implied otherwise ("will only allow plain text and HTML import/exports"), and the docker docs told users to configure soffice for DOCX as well. Update them to match what's actually in core: - soffice present: handles all office formats (existing behavior) - soffice null: docx export, pdf export, docx import work natively; odt/doc/rtf export and pdf import still need soffice Touches: - settings.json.template (soffice + docxExport comments) - settings.json.docker (same) - doc/docker.md ("Office-format import/export" section) - doc/docker.adoc (same section + the SOFFICE table row, matching what doc/docker.md already says since #7568) No code changes, no behavior change -- documentation only. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
Review Summary by QodoUpdate docs: soffice now optional for DOCX/PDF formats
WalkthroughsDescription• Update documentation to reflect native DOCX/PDF support • Clarify soffice is optional for DOCX export/import and PDF export • Document fallback behavior when soffice is null • Update settings comments to match actual implementation Diagramflowchart LR
A["soffice configured"] -->|"handles all formats"| B["DOCX/PDF/ODT/DOC/RTF"]
C["soffice null"] -->|"pure-JS converters"| D["DOCX/PDF export + DOCX import"]
C -->|"unavailable"| E["ODT/DOC/RTF export + PDF import"]
File Changes1. doc/docker.adoc
|
Code Review by Qodo
Context used✅ Tickets:
🎫 Support docx/pdf import/export natively 1. RTF export misdocumented
|
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
Summary
Follow-up to #7568. The merged PR landed native DOCX export, PDF export, and DOCX import via pure-JS in-process converters — soffice/LibreOffice is no longer required for those three formats. Several doc comments still implied otherwise:
settings.json.templateandsettings.json.dockerstill said "Setting [soffice] to null disables LibreOffice and will only allow plain text and HTML import/exports."docxExportsetting comment said it "requires 'soffice' to be set."doc/docker.mdanddoc/docker.adochad a "Rebuilding including export functionality for DOC/DOCX/PDF/ODT" section telling users to install LibreOffice for DOCX export.This PR refreshes those comments and the docker docs to reflect actual behavior:
Files
settings.json.templatesoffice+docxExportJSDoc commentssettings.json.dockerdoc/docker.mddoc/docker.adocSOFFICEtable row with the wording already indoc/docker.mdNo code changes, no behavior change — documentation only.
Refs #7538.