chore: remove basic-ftp override — lockfile resolution is sufficient#7380
Draft
chore: remove basic-ftp override — lockfile resolution is sufficient#7380
Conversation
…ransitive dependency Co-authored-by: JohnMcLear <220864+JohnMcLear@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove unused basic-ftp dependency
chore: override basic-ftp to non-deprecated safe version
Mar 19, 2026
…ly basic-ftp 5.0.5→5.2.0 change Co-authored-by: JohnMcLear <220864+JohnMcLear@users.noreply.github.com>
Copilot
AI
changed the title
chore: override basic-ftp to non-deprecated safe version
chore: remove vulnerable basic-ftp transitive dependency
Mar 19, 2026
Member
|
@copilot The problem with this pull request is that it creates an exception for this package. I don't like it, shouldn't the upstream fix be implemented IE in live-plugin-manager → proxy-agent → pac-proxy-agent → get-uri or have we fixed the verison of one of those which is why it's not landed? |
…ge already allows 5.2.0 Co-authored-by: JohnMcLear <220864+JohnMcLear@users.noreply.github.com>
Copilot
AI
changed the title
chore: remove vulnerable basic-ftp transitive dependency
chore: remove basic-ftp override — lockfile resolution is sufficient
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
pnpm.overridesexception forbasic-ftpis unnecessary.get-urialready declaresbasic-ftp@^5.0.2, which naturally satisfies5.2.0. The lockfile was simply frozen to5.0.5from a previous install; updating the pinned version directly is the correct fix.Changes
package.json: Remove thepnpm.overridesblock forbasic-ftppnpm-lock.yaml: Remove theoverridessection;basic-ftpresolves to5.2.0via the existing^5.0.2range inget-uriDependency chain for reference:
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.